You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by "Sergey Ushakov (JIRA)" <xa...@xml.apache.org> on 2005/04/10 23:25:16 UTC

[jira] Created: (XALANJ-2098) ToHTMLStream: no space between PUBLIC and SYSTEM identifiers if both present

ToHTMLStream: no space between PUBLIC and SYSTEM identifiers if both present
----------------------------------------------------------------------------

         Key: XALANJ-2098
         URL: http://issues.apache.org/jira/browse/XALANJ-2098
     Project: XalanJ2
        Type: Bug
  Components: Serialization  
    Versions: 2.6    
 Environment: n/a
    Reporter: Sergey Ushakov


The org.apache.xml.serializer.ToHTMLStream class produces invalid DOCTYPE declaration with no space between PUBLIC and SYSTEM identifiers if both are provided.

Fix:
line 607: change
   writer.write('"');
to
   writer.write(" \"");

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Updated: (XALANJ-2098) ToHTMLStream: no space between PUBLIC and SYSTEM identifiers if both present

Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XALANJ-2098?page=all ]

Brian Minchau updated XALANJ-2098:
----------------------------------

    Fix Version: 2.7

> ToHTMLStream: no space between PUBLIC and SYSTEM identifiers if both present
> ----------------------------------------------------------------------------
>
>          Key: XALANJ-2098
>          URL: http://issues.apache.org/jira/browse/XALANJ-2098
>      Project: XalanJ2
>         Type: Bug
>   Components: Serialization
>     Versions: 2.6
>  Environment: n/a
>     Reporter: Sergey Ushakov
>      Fix For: 2.7

>
> The org.apache.xml.serializer.ToHTMLStream class produces invalid DOCTYPE declaration with no space between PUBLIC and SYSTEM identifiers if both are provided.
> Fix:
> line 607: change
>    writer.write('"');
> to
>    writer.write(" \"");

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Resolved: (XALANJ-2098) ToHTMLStream: no space between PUBLIC and SYSTEM identifiers if both present

Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XALANJ-2098?page=history ]
     
Brian Minchau resolved XALANJ-2098:
-----------------------------------

    Resolution: Duplicate

Probably a duplicate of an earlier bug. Resolving as duplicate, but it is already fixed in CVS.

> ToHTMLStream: no space between PUBLIC and SYSTEM identifiers if both present
> ----------------------------------------------------------------------------
>
>          Key: XALANJ-2098
>          URL: http://issues.apache.org/jira/browse/XALANJ-2098
>      Project: XalanJ2
>         Type: Bug
>   Components: Serialization
>     Versions: 2.6
>  Environment: n/a
>     Reporter: Sergey Ushakov

>
> The org.apache.xml.serializer.ToHTMLStream class produces invalid DOCTYPE declaration with no space between PUBLIC and SYSTEM identifiers if both are provided.
> Fix:
> line 607: change
>    writer.write('"');
> to
>    writer.write(" \"");

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Commented: (XALANJ-2098) ToHTMLStream: no space between PUBLIC and SYSTEM identifiers if both present

Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XALANJ-2098?page=comments#action_62561 ]
     
Brian Minchau commented on XALANJ-2098:
---------------------------------------

Sergey, the current code in CVS in ToHTMLStream.startDocumentInternal(), is more or less this:

writer.write("<!DOCTYPE HTML");
if (null != doctypePublic)
{
  writer.write(" PUBLIC \"");
  writer.write(doctypePublic);
  writer.write('"');
}
if (null != doctypeSystem)
{
  if (null == doctypePublic)
    writer.write(" SYSTEM \"");
  else
    writer.write(" \""); // - - - THE LINE - - -
  writer.write(doctypeSystem);
  writer.write('"');
}
writer.write('>');

I think that the line you are refereing to, is the one I've marked
as "- - - THE LINE - - -". So you can confirm that the problem that
you report is already fixed in CVS, though not in a release yet.

Thanks,
Brian


> ToHTMLStream: no space between PUBLIC and SYSTEM identifiers if both present
> ----------------------------------------------------------------------------
>
>          Key: XALANJ-2098
>          URL: http://issues.apache.org/jira/browse/XALANJ-2098
>      Project: XalanJ2
>         Type: Bug
>   Components: Serialization
>     Versions: 2.6
>  Environment: n/a
>     Reporter: Sergey Ushakov

>
> The org.apache.xml.serializer.ToHTMLStream class produces invalid DOCTYPE declaration with no space between PUBLIC and SYSTEM identifiers if both are provided.
> Fix:
> line 607: change
>    writer.write('"');
> to
>    writer.write(" \"");

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Commented: (XALANJ-2098) ToHTMLStream: no space between PUBLIC and SYSTEM identifiers if both present

Posted by "Sergey Ushakov (JIRA)" <xa...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XALANJ-2098?page=comments#action_62575 ]
     
Sergey Ushakov commented on XALANJ-2098:
----------------------------------------

Yes, that is exactly what I meant. I can confirm that the current code in the CVS is ok.

I'll look better in the CVS next time... :)

> ToHTMLStream: no space between PUBLIC and SYSTEM identifiers if both present
> ----------------------------------------------------------------------------
>
>          Key: XALANJ-2098
>          URL: http://issues.apache.org/jira/browse/XALANJ-2098
>      Project: XalanJ2
>         Type: Bug
>   Components: Serialization
>     Versions: 2.6
>  Environment: n/a
>     Reporter: Sergey Ushakov

>
> The org.apache.xml.serializer.ToHTMLStream class produces invalid DOCTYPE declaration with no space between PUBLIC and SYSTEM identifiers if both are provided.
> Fix:
> line 607: change
>    writer.write('"');
> to
>    writer.write(" \"");

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org