You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Lukas Theussl (JIRA)" <ji...@codehaus.org> on 2011/05/23 20:22:22 UTC
[jira] Created: (MSITE-585) site-deploy: empty deploy protocol when
properties are used
site-deploy: empty deploy protocol when properties are used
-----------------------------------------------------------
Key: MSITE-585
URL: http://jira.codehaus.org/browse/MSITE-585
Project: Maven 2.x and 3.x Site Plugin
Issue Type: Bug
Components: inheritance
Affects Versions: 2.3
Reporter: Lukas Theussl
See http://www.mail-archive.com/dev@maven.apache.org/msg88029.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MSITE-585) site-deploy: empty deploy protocol when
properties are used
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSITE-585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukas Theussl closed MSITE-585.
-------------------------------
Resolution: Fixed
Fix Version/s: 2.4
Assignee: Lukas Theussl
Fixed in [r1145546|http://svn.apache.org/viewvc?rev=1145546&view=rev]. Please note remarks above.
> site-deploy: empty deploy protocol when properties are used
> -----------------------------------------------------------
>
> Key: MSITE-585
> URL: https://jira.codehaus.org/browse/MSITE-585
> Project: Maven 2.x and 3.x Site Plugin
> Issue Type: Bug
> Components: property interpolation
> Affects Versions: 2.3
> Reporter: Lukas Theussl
> Assignee: Lukas Theussl
> Fix For: 2.4
>
>
> See http://www.mail-archive.com/dev@maven.apache.org/msg88029.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSITE-585) site-deploy: empty deploy protocol
when properties are used
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSITE-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=274464#comment-274464 ]
Benson Margulies commented on MSITE-585:
----------------------------------------
OK, the test case I attached 'works' for 2.4-SNAPSHOT, but exhibits another problem I'll report separately.
> site-deploy: empty deploy protocol when properties are used
> -----------------------------------------------------------
>
> Key: MSITE-585
> URL: https://jira.codehaus.org/browse/MSITE-585
> Project: Maven 2.x and 3.x Site Plugin
> Issue Type: Bug
> Components: property interpolation
> Affects Versions: 2.3
> Reporter: Lukas Theussl
> Assignee: Lukas Theussl
> Fix For: 2.4
>
> Attachments: muddle.tar
>
>
> See http://www.mail-archive.com/dev@maven.apache.org/msg88029.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSITE-585) site-deploy: empty deploy protocol
when properties are used
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSITE-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=268436#action_268436 ]
Lukas Theussl commented on MSITE-585:
-------------------------------------
According to MNG-1943 this should work with m3, but apparently it doesn't. I have merged the interpolation IT from trunk: http://svn.apache.org/viewvc?rev=1127453&view=rev.
> site-deploy: empty deploy protocol when properties are used
> -----------------------------------------------------------
>
> Key: MSITE-585
> URL: http://jira.codehaus.org/browse/MSITE-585
> Project: Maven 2.x and 3.x Site Plugin
> Issue Type: Bug
> Components: inheritance
> Affects Versions: 2.3
> Reporter: Lukas Theussl
>
> See http://www.mail-archive.com/dev@maven.apache.org/msg88029.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSITE-585) site-deploy: empty deploy protocol
when properties are used
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSITE-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=273059#comment-273059 ]
Lukas Theussl commented on MSITE-585:
-------------------------------------
The problem arises when the distMgmnt section is inherited from the parent but uses properties that are only defined in the child. I am not sure if this is supposed to be a supported use-case, it is certainly not best practice (e.g. the parent pom will not be deployable by itself). Inheritance only works from parent to child, not from child to parent.
This probably only worked in older versions of the site plugin because the parent site url was not used for deploy. This is not the case anymore since site-plugin-2.3 to fix some other issues with multi-module deploy, eg MSITE-537.
Note:
*) according to the [docs|http://maven.apache.org/plugins/maven-site-plugin/usage.html] ??''If subprojects inherit the site URL from a parent POM, they will automatically append their <artifactId> to form their effective deployment location.''?? so even in the original setup of the IT the resulting deploy location is probably not what was intented, as given by ${site.repository}.
*) as per remarks above, the parent pom has to include some default values for any used properties. Those may be overridden by inheriting poms, but each pom needs to be fully resolvable based on its own inheritance structure.
> site-deploy: empty deploy protocol when properties are used
> -----------------------------------------------------------
>
> Key: MSITE-585
> URL: https://jira.codehaus.org/browse/MSITE-585
> Project: Maven 2.x and 3.x Site Plugin
> Issue Type: Bug
> Components: property interpolation
> Affects Versions: 2.3
> Reporter: Lukas Theussl
>
> See http://www.mail-archive.com/dev@maven.apache.org/msg88029.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSITE-585) site-deploy: empty deploy protocol
when properties are used
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSITE-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=274457#comment-274457 ]
Benson Margulies commented on MSITE-585:
----------------------------------------
I seem to have run into a variation on this theme.
Parent has a distributionManagement that has property references.
Child completely overrides it:
<distributionManagement>
<site>
<id>parent.website</id>
<url>scp://souvenir.basistech.net:/basis/trees/maven-projects/oap/parent</url>
</site>
</distributionManagement>
Yet I still get the error, and -X shows that the site plugin is using the value of <url> from the parent, not from the current project.
> site-deploy: empty deploy protocol when properties are used
> -----------------------------------------------------------
>
> Key: MSITE-585
> URL: https://jira.codehaus.org/browse/MSITE-585
> Project: Maven 2.x and 3.x Site Plugin
> Issue Type: Bug
> Components: property interpolation
> Affects Versions: 2.3
> Reporter: Lukas Theussl
> Assignee: Lukas Theussl
> Fix For: 2.4
>
>
> See http://www.mail-archive.com/dev@maven.apache.org/msg88029.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSITE-585) site-deploy: empty deploy protocol when
properties are used
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSITE-585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MSITE-585:
-----------------------------------
Attachment: muddle.tar
Test case which suggests that this might not be all fixed yet.
> site-deploy: empty deploy protocol when properties are used
> -----------------------------------------------------------
>
> Key: MSITE-585
> URL: https://jira.codehaus.org/browse/MSITE-585
> Project: Maven 2.x and 3.x Site Plugin
> Issue Type: Bug
> Components: property interpolation
> Affects Versions: 2.3
> Reporter: Lukas Theussl
> Assignee: Lukas Theussl
> Fix For: 2.4
>
> Attachments: muddle.tar
>
>
> See http://www.mail-archive.com/dev@maven.apache.org/msg88029.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSITE-585) site-deploy: empty deploy protocol
when properties are used
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSITE-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=268429#action_268429 ]
Lukas Theussl commented on MSITE-585:
-------------------------------------
The root cause is the use of MavenProject.getParent() in getRootSite of AbstractDeployMojo, apparently this always returns the un-interpolated parent project. How to get the interpolated one?
> site-deploy: empty deploy protocol when properties are used
> -----------------------------------------------------------
>
> Key: MSITE-585
> URL: http://jira.codehaus.org/browse/MSITE-585
> Project: Maven 2.x and 3.x Site Plugin
> Issue Type: Bug
> Components: inheritance
> Affects Versions: 2.3
> Reporter: Lukas Theussl
>
> See http://www.mail-archive.com/dev@maven.apache.org/msg88029.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira