You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/08/13 00:57:50 UTC
[GitHub] [hive] belugabehr opened a new pull request, #3518: HIVE-26469: Remove stringifyException Method From QL Package
belugabehr opened a new pull request, #3518:
URL: https://github.com/apache/hive/pull/3518
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #3518: HIVE-26469: Remove stringifyException Method From QL Package
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #3518: HIVE-26469: Remove stringifyException Method From QL Package
URL: https://github.com/apache/hive/pull/3518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on a diff in pull request #3518: HIVE-26469: Remove stringifyException Method From QL Package
Posted by GitBox <gi...@apache.org>.
zabetak commented on code in PR #3518:
URL: https://github.com/apache/hive/pull/3518#discussion_r951459418
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordSource.java:
##########
@@ -373,8 +370,7 @@ public void next() throws HiveException {
try {
rowString = SerDeUtils.getJSONString(row, rowObjectInspector);
} catch (Exception e2) {
- rowString = "[Error getting row data with exception "
- + StringUtils.stringifyException(e2) + " ]";
+ l4j.trace("Error getting row data (tag={})", tag, e2);
Review Comment:
The refactoring in `ExecReducer` was a bit different. Maybe it makes sense to keep things uniform.
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordSource.java:
##########
@@ -502,8 +495,7 @@ private void processVectorGroup(BytesWritable keyWritable,
try {
rowString = batch.toString();
} catch (Exception e2) {
- rowString = "[Error getting row data with exception "
- + StringUtils.stringifyException(e2) + " ]";
+ l4j.error("Error getting row data (tag={})", tag, e2);
Review Comment:
The refactoring in `ExecReducer` is different.
Moreover, previously we used `l4j.trace` and here we use `l4j.error`. The discussion in `HIVE-20644` indicates that maybe it is safer to log at trace level when it comes to data. This is outside the scope of this PR but maybe worth filing a JIRA case for this.
##########
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java:
##########
@@ -286,11 +286,7 @@ public void iterate(AggregationBuffer agg, Object[] parameters) throws HiveExcep
} catch (NumberFormatException e) {
if (!warned) {
warned = true;
- LOG.warn(getClass().getSimpleName() + " "
- + StringUtils.stringifyException(e));
- LOG
- .warn(getClass().getSimpleName()
- + " ignoring similar exceptions.");
+ LOG.warn("{}: ignoring similar exceptions", getClass().getSimpleName(), e);
Review Comment:
Remove unused `import org.apache.hadoop.util.StringUtils;`
##########
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java:
##########
@@ -286,11 +286,7 @@ public void iterate(AggregationBuffer agg, Object[] parameters) throws HiveExcep
} catch (NumberFormatException e) {
if (!warned) {
warned = true;
- LOG.warn(getClass().getSimpleName() + " "
- + StringUtils.stringifyException(e));
- LOG
- .warn(getClass().getSimpleName()
- + " ignoring similar exceptions.");
+ LOG.warn("{}: ignoring similar exceptions", getClass().getSimpleName(), e);
Review Comment:
The `getClass().getSimpleName()` is a bit useless/redundant for two reasons:
* The class name will appear in the stacktrace;
* The log configuration can be changed to include the class name if necessary.
The comment applies to all changes in this class.
The proposed refactoring though simply retains the old behavior so this is not a blocking comment.
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordSource.java:
##########
@@ -398,15 +394,12 @@ private boolean pushRecordVector() {
processVectorGroup(keyWritable, valueWritables, tag);
return true;
- } catch (Throwable e) {
+ } catch (OutOfMemoryError oom) {
abort = true;
- if (e instanceof OutOfMemoryError) {
- // Don't create a new object if we are already out of memory
- throw (OutOfMemoryError) e;
- } else {
- l4j.error(StringUtils.stringifyException(e));
- throw new RuntimeException(e);
- }
+ // Do not create a new object if we are already out of memory
+ throw oom;
+ } catch (Throwable t) {
+ throw new RuntimeException(t);
Review Comment:
`abort = true;` is missing here. This is the only major review comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #3518: HIVE-26469: Remove stringifyException Method From QL Package
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3518:
URL: https://github.com/apache/hive/pull/3518#issuecomment-1287555979
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org