You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by discipleforteen <gi...@git.apache.org> on 2017/01/17 09:34:25 UTC
[GitHub] spark pull request #16612: [SPARK-19225][SQL]round decimal return the same v...
GitHub user discipleforteen opened a pull request:
https://github.com/apache/spark/pull/16612
[SPARK-19225][SQL]round decimal return the same value as spark 1.x
## What changes were proposed in this pull request?
in https://issues.apache.org/jira/browse/SPARK-19225,
change the round decimal function. select round(4.4, 2) can return 4.4 , not return null
## How was this patch tested?
unit test
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/discipleforteen/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16612.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16612
----
commit ff19e1fd5a7e84268cc67ef1c20766e4a3eb0317
Author: discipleforteen <32...@qq.com>
Date: 2017-01-17T09:23:24Z
mathExpressions modify
modify round scala
commit 4b450dec70517abdf0a437689d2376e0f73ff077
Author: discipleforteen <32...@qq.com>
Date: 2017-01-17T09:28:45Z
Merge pull request #1 from discipleforteen/discipleforteen-patch-1
[SPARK-19225][SQL]round decimal return the same value as spark 1.x
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16612: [SPARK-19225][SQL]round decimal return the same value as...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16612
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16612: [SPARK-19225][SQL]round decimal return the same v...
Posted by discipleforteen <gi...@git.apache.org>.
Github user discipleforteen closed the pull request at:
https://github.com/apache/spark/pull/16612
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org