You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by Thomas Herzog <t....@curecomp.com> on 2012/07/04 11:13:18 UTC
ExceptionHandler chain is broken with same ordinal
We are using deltaspike-core-api-0.2-incubating.
When there are multiple observer methods found for an ExceptionEvent with the same type then only one observer method is called when event is not marked as handled.
If we explicitly define a ordinal (handler one = 1, handler two = 2) then both get invoked in the expected order.
The spec says if ordinal is not defined or multiple handler methods are found with same ordinal then the order is non-deterministic.
So I think that this is a bug.
Am I right ?
Mit freundlichen Grüßen
Thomas Herzog
Softwareentwicklung
curecomp Software Services GmbH
Hafenstrasse 47-51
4020 Linz
web: www.curecomp.com <http://www.curecomp.com/>
e-Mail: t.herzog@curecomp.com <ma...@curecomp.com>
tel: +43 (0)732 9015-5563
mobile: +43 (0)664 8867 9829
Re: ExceptionHandler chain is broken with same ordinal
Posted by Jason Porter <li...@gmail.com>.
I'll look at it today or tomorrow (hopefully today)
On Wed, Jul 4, 2012 at 6:44 AM, Thomas Herzog <t....@curecomp.com> wrote:
> I have created an issue on JIRA DELTASPIKE-218.
>
> ExceptionHandling:
> -------------------------
> There is one feature which would be fine for ExceptionHandling.
> Imagine there is an observer chain with non-deterministic order, where
> anyone but only one is supposed to handle the exception.
> If no one has handled it then you cannot handle this.
> So I thought it would fine to have an observer method which gets invoked
> when no observer method in the chain marks the event as handled.
>
> For instance:
> ------------------
> handleUnHandled(@HandlesUnHandled){ // Populate error that no
> ExceptionHandler were able to handle thrown exception ...}
>
> I18N:
> ------
> As we tried out, it seems it is not able to define a BasePath for the
> properties files, so they have always to be on same level as the
> @MessageBundle annotated class is.
> We do have them in META-INF/messages/*.properties and do not want to put
> them into the package structure.
> Also the keys defined in @MessageTemplate has to be static final String,
> we uses Enums.
>
> Example:
> ------------
> Enum:
> enum Keys() {
> KEY_1,
> KEY_2
> }
>
> Strings (In my opinion double work !!):
> class Keys{
> KEY_1 = "KEY_1";
> KEY_2 = "KEY_2";
> }
>
> Mit freundlichen Grüßen
>
> Thomas Herzog
> Softwareentwicklung
>
> curecomp Software Services GmbH
> Hafenstrasse 47-51
> 4020 Linz
>
> web: www.curecomp.com
> e-Mail: t.herzog@curecomp.com
> tel: +43 (0)732 9015-5563
> mobile: +43 (0)664 8867 9829
>
>
>
>
> -----Ursprüngliche Nachricht-----
> Von: Mark Struberg [mailto:struberg@yahoo.de]
> Gesendet: Mittwoch, 04. Juli 2012 11:54
> An: deltaspike-dev@incubator.apache.org
> Betreff: Re: ExceptionHandler chain is broken with same ordinal
>
>
>
> yes, this sounds very much like a bug. Please file a Jira Issue in
>
> https://issues.apache.org/jira/browse/DELTASPIKE
>
> Hope you like DeltaSpike! Feel free to ask questions and we are also happy
> about every bug report and info about missing features we should address!
>
> LieGrue,
> strub
>
> >________________________________
> > From: Thomas Herzog <t....@curecomp.com>
> >To: deltaspike-dev@incubator.apache.org
> >Sent: Wednesday, July 4, 2012 11:13 AM
> >Subject: ExceptionHandler chain is broken with same ordinal
> >
> >
> >We are using deltaspike-core-api-0.2-incubating.
> >
> >When there are multiple observer methods found for an ExceptionEvent with
> the same type then only one observer method is called when event is not
> marked as handled.
> >If we explicitly define a ordinal (handler one = 1, handler two = 2) then
> both get invoked in the expected order.
> >The spec says if ordinal is not defined or multiple handler methods are
> found with same ordinal then the order is non-deterministic.
> >So I think that this is a bug.
> >Am I right ?
> >
> >
> >Mit freundlichen Grüßen
> >
> >Thomas Herzog
> >Softwareentwicklung
> >
> >curecomp Software Services GmbH
> >Hafenstrasse 47-51
> >4020 Linz
> >
> >web: www.curecomp.com
> >e-Mail: t.herzog@curecomp.com
> >tel: +43 (0)732 9015-5563
> >mobile: +43 (0)664 8867 9829
> >
> >
> >
> >
> >
>
--
Jason Porter
http://lightguard-jp.blogspot.com
http://twitter.com/lightguardjp
Software Engineer
Open Source Advocate
Author of Seam Catch - Next Generation Java Exception Handling
PGP key id: 926CCFF5
PGP key available at: keyserver.net, pgp.mit.edu
AW: ExceptionHandler chain is broken with same ordinal
Posted by Thomas Herzog <t....@curecomp.com>.
I have created an issue on JIRA DELTASPIKE-218.
ExceptionHandling:
-------------------------
There is one feature which would be fine for ExceptionHandling.
Imagine there is an observer chain with non-deterministic order, where anyone but only one is supposed to handle the exception.
If no one has handled it then you cannot handle this.
So I thought it would fine to have an observer method which gets invoked when no observer method in the chain marks the event as handled.
For instance:
------------------
handleUnHandled(@HandlesUnHandled){ // Populate error that no ExceptionHandler were able to handle thrown exception ...}
I18N:
------
As we tried out, it seems it is not able to define a BasePath for the properties files, so they have always to be on same level as the @MessageBundle annotated class is.
We do have them in META-INF/messages/*.properties and do not want to put them into the package structure.
Also the keys defined in @MessageTemplate has to be static final String, we uses Enums.
Example:
------------
Enum:
enum Keys() {
KEY_1,
KEY_2
}
Strings (In my opinion double work !!):
class Keys{
KEY_1 = "KEY_1";
KEY_2 = "KEY_2";
}
Mit freundlichen Grüßen
Thomas Herzog
Softwareentwicklung
curecomp Software Services GmbH
Hafenstrasse 47-51
4020 Linz
web: www.curecomp.com
e-Mail: t.herzog@curecomp.com
tel: +43 (0)732 9015-5563
mobile: +43 (0)664 8867 9829
-----Ursprüngliche Nachricht-----
Von: Mark Struberg [mailto:struberg@yahoo.de]
Gesendet: Mittwoch, 04. Juli 2012 11:54
An: deltaspike-dev@incubator.apache.org
Betreff: Re: ExceptionHandler chain is broken with same ordinal
yes, this sounds very much like a bug. Please file a Jira Issue in
https://issues.apache.org/jira/browse/DELTASPIKE
Hope you like DeltaSpike! Feel free to ask questions and we are also happy about every bug report and info about missing features we should address!
LieGrue,
strub
>________________________________
> From: Thomas Herzog <t....@curecomp.com>
>To: deltaspike-dev@incubator.apache.org
>Sent: Wednesday, July 4, 2012 11:13 AM
>Subject: ExceptionHandler chain is broken with same ordinal
>
>
>We are using deltaspike-core-api-0.2-incubating.
>
>When there are multiple observer methods found for an ExceptionEvent with the same type then only one observer method is called when event is not marked as handled.
>If we explicitly define a ordinal (handler one = 1, handler two = 2) then both get invoked in the expected order.
>The spec says if ordinal is not defined or multiple handler methods are found with same ordinal then the order is non-deterministic.
>So I think that this is a bug.
>Am I right ?
>
>
>Mit freundlichen Grüßen
>
>Thomas Herzog
>Softwareentwicklung
>
>curecomp Software Services GmbH
>Hafenstrasse 47-51
>4020 Linz
>
>web: www.curecomp.com
>e-Mail: t.herzog@curecomp.com
>tel: +43 (0)732 9015-5563
>mobile: +43 (0)664 8867 9829
>
>
>
>
>
Re: ExceptionHandler chain is broken with same ordinal
Posted by Mark Struberg <st...@yahoo.de>.
yes, this sounds very much like a bug. Please file a Jira Issue in
https://issues.apache.org/jira/browse/DELTASPIKE
Hope you like DeltaSpike! Feel free to ask questions and we are also happy about every bug report and info about missing features we should address!
LieGrue,
strub
>________________________________
> From: Thomas Herzog <t....@curecomp.com>
>To: deltaspike-dev@incubator.apache.org
>Sent: Wednesday, July 4, 2012 11:13 AM
>Subject: ExceptionHandler chain is broken with same ordinal
>
>
>We are using deltaspike-core-api-0.2-incubating.
>
>When there are multiple observer methods found for an ExceptionEvent with the same type then only one observer method is called when event is not marked as handled.
>If we explicitly define a ordinal (handler one = 1, handler two = 2) then both get invoked in the expected order.
>The spec says if ordinal is not defined or multiple handler methods are found with same ordinal then the order is non-deterministic.
>So I think that this is a bug.
>Am I right ?
>
>
>Mit freundlichen Grüßen
>
>Thomas Herzog
>Softwareentwicklung
>
>curecomp Software Services GmbH
>Hafenstrasse 47-51
>4020 Linz
>
>web: www.curecomp.com
>e-Mail: t.herzog@curecomp.com
>tel: +43 (0)732 9015-5563
>mobile: +43 (0)664 8867 9829
>
>
>
>
>