[GitHub] [netbeans] lbownik commented on a diff in pull request #5853: Fix for PHPUnit 10 #5790

["lbownik (via GitHub)" <gi...@apache.org>]

lbownik commented on code in PR #5853:
URL: https://github.com/apache/netbeans/pull/5853#discussion_r1172181368


##########
php/php.phpunit/src/org/netbeans/modules/php/phpunit/ui/customizer/CustomizerPhpUnit.java:
##########
@@ -603,4 +632,23 @@ private void processUpdate() {
         }
     }
 
+    private static class PhpUnitVersionComboBoxModel extends DefaultComboBoxModel<PhpUnitVersion> {
+
+        private static final long serialVersionUID = 5850175934190021687L;
+
+        public PhpUnitVersionComboBoxModel() {
+            this(null);
+        }
+
+        public PhpUnitVersionComboBoxModel(PhpUnitVersion preselected) {
+            super(PhpUnitVersion.values());
+
+            if (preselected != null) {
+                setSelectedItem(preselected);

Review Comment:
   how about
   setSelectedItem(preselected != null ? preselected : PhpUnitVersion.getDefault());



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists