You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/02/23 13:41:50 UTC
[GitHub] codecov-io edited a comment on issue #536: SCB-1092 More abundant
metrics information
codecov-io edited a comment on issue #536: SCB-1092 More abundant metrics information
URL: https://github.com/apache/servicecomb-service-center/pull/536#issuecomment-466019039
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/536?src=pr&el=h1) Report
> Merging [#536](https://codecov.io/gh/apache/servicecomb-service-center/pull/536?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/e1c525cccfa020c9e65212326c76fc20df348cd6?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `93.33%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/536?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #536 +/- ##
==========================================
- Coverage 57.99% 57.95% -0.05%
==========================================
Files 185 185
Lines 14782 14792 +10
==========================================
- Hits 8573 8572 -1
- Misses 5613 5622 +9
- Partials 596 598 +2
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/536?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/notify/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/536/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS93ZWJzb2NrZXQuZ28=) | `81.97% <100%> (+0.31%)` | :arrow_up: |
| [server/notify/metrics.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/536/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS9tZXRyaWNzLmdv) | `84.61% <100%> (+4.61%)` | :arrow_up: |
| [server/notify/stream.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/536/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS9zdHJlYW0uZ28=) | `71.05% <87.5%> (+0.46%)` | :arrow_up: |
| [server/notify/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/536/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS9saXN0d2F0Y2hlci5nbw==) | `69.44% <0%> (-9.73%)` | :arrow_down: |
| [pkg/gopool/goroutines.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/536/diff?src=pr&el=tree#diff-cGtnL2dvcG9vbC9nb3JvdXRpbmVzLmdv) | `97.36% <0%> (-2.64%)` | :arrow_down: |
| [server/service/util/dependency.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/536/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv) | `46.87% <0%> (-1.57%)` | :arrow_down: |
| [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/536/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: |
| [server/broker/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/536/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.94% <0%> (+0.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/536?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/536?src=pr&el=footer). Last update [e1c525c...fb12a46](https://codecov.io/gh/apache/servicecomb-service-center/pull/536?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services