[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2592: ARTEMIS-2285 Sorting by user column in connections view not working

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #2592: ARTEMIS-2285 Sorting by user column in connections view not working
URL: https://github.com/apache/activemq-artemis/pull/2592#discussion_r273719449
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConnectionView.java
 ##########
 @@ -83,12 +83,12 @@ public Object getField(RemotingConnection connection, String fieldName) {
          case "remoteAddress":
             return connection.getRemoteAddress();
          case "users":
-            Set<String> users = new HashSet<>();
+            Set<String> users = new TreeSet<>();
             for (ServerSession session : sessions) {
                String username = session.getUsername() == null ? "" : session.getUsername();
                users.add(username);
             }
-            return users;
+            return StringUtil.joinStringList(users, ",");
 
 Review comment:
   Whilst i understand treeset to give ordering by insert, the return shouldn't change the type, e.g just return users still. Or im missing something.... i guess a test may help to describe/show why its needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services