You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "wilfred-s (via GitHub)" <gi...@apache.org> on 2023/02/07 04:49:02 UTC
[GitHub] [yunikorn-k8shim] wilfred-s opened a new pull request, #522: [YUNIKORN-1562] plugin: remove pod status update
wilfred-s opened a new pull request, #522:
URL: https://github.com/apache/yunikorn-k8shim/pull/522
### What is this PR for?
The k8shim in plugin mode updates the pod status to move the pod from the unschedulablePods structure to the activeQ. The state change was added to the plugin code based on an incorrect assumption that it would trigger a move between the unschedulablePods and activeQ. However, the scheduler explicitly excluded pod status when checking for updates.
### What type of PR is it?
* [X] - Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1562
### How should this be tested?
e2e tests for the plugin must pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #522: [YUNIKORN-1562] plugin: remove pod status update
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #522:
URL: https://github.com/apache/yunikorn-k8shim/pull/522#issuecomment-1420204053
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/522?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#522](https://codecov.io/gh/apache/yunikorn-k8shim/pull/522?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2917a7a) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/a9cdd44d9785c883f6bf4e0a926b824368132767?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9cdd44) will **increase** coverage by `0.05%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #522 +/- ##
==========================================
+ Coverage 69.41% 69.47% +0.05%
==========================================
Files 45 45
Lines 7714 7708 -6
==========================================
Hits 5355 5355
+ Misses 2162 2156 -6
Partials 197 197
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/522?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/task.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/522?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `68.81% <0.00%> (+1.00%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #522: [YUNIKORN-1562] plugin: remove pod status update
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #522: [YUNIKORN-1562] plugin: remove pod status update
URL: https://github.com/apache/yunikorn-k8shim/pull/522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org