You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/02/13 17:43:13 UTC
[GitHub] [bookkeeper] dianacle opened a new pull request #2603: Fix for licenses problems
dianacle opened a new pull request #2603:
URL: https://github.com/apache/bookkeeper/pull/2603
Fix problems found with check-binary-licence
Master Issue: #2592
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2603: Fix for licenses problems
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2603:
URL: https://github.com/apache/bookkeeper/pull/2603#issuecomment-778676044
Great work @dianacle
Can you please add my PR in order to trigger the validation?
https://github.com/apache/bookkeeper/pull/2600
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2603: Fix for licenses problems
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2603:
URL: https://github.com/apache/bookkeeper/pull/2603#issuecomment-778766808
In my pr the validation found the files
https://github.com/apache/bookkeeper/pull/2600
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2603: Fix for licenses problems
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2603:
URL: https://github.com/apache/bookkeeper/pull/2603#issuecomment-778766538
rerun failed tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #2603: Fix for licenses problems
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2603:
URL: https://github.com/apache/bookkeeper/pull/2603
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dianacle closed pull request #2603: Fix for licenses problems
Posted by GitBox <gi...@apache.org>.
dianacle closed pull request #2603:
URL: https://github.com/apache/bookkeeper/pull/2603
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dianacle commented on pull request #2603: Fix for licenses problems
Posted by GitBox <gi...@apache.org>.
dianacle commented on pull request #2603:
URL: https://github.com/apache/bookkeeper/pull/2603#issuecomment-778745817
> Great work @dianacle
>
> Can you please add my PR in order to trigger the validation?
> #2600
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2603: Fix for licenses problems
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2603:
URL: https://github.com/apache/bookkeeper/pull/2603#issuecomment-779013901
Committed to master branch,
thank you @dianacle
now we are ready for a release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dianacle commented on a change in pull request #2603: Fix for licenses problems
Posted by GitBox <gi...@apache.org>.
dianacle commented on a change in pull request #2603:
URL: https://github.com/apache/bookkeeper/pull/2603#discussion_r575808175
##########
File path: dev/check-all-licenses
##########
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Script to check licenses on a binary tarball.
+# It extracts the list of bundled jars, the NOTICE, and the LICENSE
+# files. It checked that every non-bk jar bundled is mentioned in the
+# LICENSE file. It checked that all jar files mentioned in NOTICE and
+# LICENSE are actually bundled.
+
+# all error fatal
+set -e -x
+
+HERE=$(dirname $0)
+BOOKKEEPER_DIST=$HERE/../bookkeeper-dist
+$HERE/check-binary-license $BOOKKEEPER_DIST/server/target/bookkeeper-server-*-bin.tar.gz
+$HERE/check-binary-license $BOOKKEEPER_DIST/server/all/bookkeeper-all-*-bin.tar.gz
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2603: Fix for licenses problems
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2603:
URL: https://github.com/apache/bookkeeper/pull/2603#issuecomment-778766673
It looks like my script is not finding the binary tarballs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2603: Fix for licenses problems
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #2603:
URL: https://github.com/apache/bookkeeper/pull/2603#discussion_r575799147
##########
File path: dev/check-all-licenses
##########
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Script to check licenses on a binary tarball.
+# It extracts the list of bundled jars, the NOTICE, and the LICENSE
+# files. It checked that every non-bk jar bundled is mentioned in the
+# LICENSE file. It checked that all jar files mentioned in NOTICE and
+# LICENSE are actually bundled.
+
+# all error fatal
+set -e -x
+
+HERE=$(dirname $0)
+BOOKKEEPER_DIST=$HERE/../bookkeeper-dist
+$HERE/check-binary-license $BOOKKEEPER_DIST/server/target/bookkeeper-server-*-bin.tar.gz
+$HERE/check-binary-license $BOOKKEEPER_DIST/server/all/bookkeeper-all-*-bin.tar.gz
Review comment:
The script is wrong!
In my branch it failed during the validation of 'server' package.
But now the validation is passing :)
And now the path of the second and the third files are wrong
Can you please fix it @dianacle ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org