You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/25 14:33:45 UTC
[GitHub] [incubator-nuttx] slorquet opened a new pull request #3781: user correct printf specifiers
slorquet opened a new pull request #3781:
URL: https://github.com/apache/incubator-nuttx/pull/3781
## Summary
Remove a warning
## Impact
None
## Testing
Tested in our own board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] slorquet commented on pull request #3781: user correct printf specifiers
Posted by GitBox <gi...@apache.org>.
slorquet commented on pull request #3781:
URL: https://github.com/apache/incubator-nuttx/pull/3781#issuecomment-848247942
I have others qualifiers for linux contributions but I'm not sure we want to read them here :p
Are there specific rules to split string litterals or anything that fits 80 columns is okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3781: use correct printf specifiers
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3781:
URL: https://github.com/apache/incubator-nuttx/pull/3781#issuecomment-848667698
> I have pushed a commit to fix the long line and tested my ability to use the rebase mechanism. This required a force push but thats okay.
Good, thank you!
Please squash your commits!
$ git rebase -i HEAD~2
(put squash in the second commit)
$ git push -f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3781: use correct printf specifiers
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3781:
URL: https://github.com/apache/incubator-nuttx/pull/3781#issuecomment-848728405
Hahaha, nothing! You are done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] slorquet commented on pull request #3781: user correct printf specifiers
Posted by GitBox <gi...@apache.org>.
slorquet commented on pull request #3781:
URL: https://github.com/apache/incubator-nuttx/pull/3781#issuecomment-848218627
Contributing to this project is now a nightmare.
i KNOW the line is long.
How do you format a long string literal like that one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3781: user correct printf specifiers
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3781:
URL: https://github.com/apache/incubator-nuttx/pull/3781#discussion_r639179141
##########
File path: drivers/eeprom/spi_xx25xx.c
##########
@@ -850,7 +850,7 @@ int ee25xx_initialize(FAR struct spi_dev_s *dev, FAR char *devname,
eedev->readonly = !!readonly;
- finfo("EEPROM device %s, %d bytes, %d per page, addrlen %d, readonly %d\n",
+ finfo("EEPROM device %s, %"PRIu32" bytes, %u per page, addrlen %u, readonly %d\n",
devname, eedev->size, eedev->pgsize, eedev->addrlen, eedev->readonly);
Review comment:
```suggestion
finfo("EEPROM device %s, %" PRIu32 " bytes, %u per page, addrlen %u, "
"readonly %d\n", devname, eedev->size, eedev->pgsize,
eedev->addrlen, eedev->readonly);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on pull request #3781: user correct printf specifiers
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on pull request #3781:
URL: https://github.com/apache/incubator-nuttx/pull/3781#issuecomment-848243442
> How do you format a long string literal like that one?
The C language supports the concatenation of string literals in several ways.
I've just added a suggestion of one of the possibilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] slorquet commented on pull request #3781: user correct printf specifiers
Posted by GitBox <gi...@apache.org>.
slorquet commented on pull request #3781:
URL: https://github.com/apache/incubator-nuttx/pull/3781#issuecomment-848631751
I have pushed a commit to fix the long line and tested my ability to use the rebase mechanism. This required a force push but thats okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3781: user correct printf specifiers
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3781:
URL: https://github.com/apache/incubator-nuttx/pull/3781#issuecomment-848251633
> I have others qualifiers for linux contributions but I'm not sure we want to read them here :p
>
> Are there specific rules to split string litterals or anything that fits 80 columns is okay?
Basically if you don't pass the 78 column, everything is fine.
All information you need is explained here: https://cwiki.apache.org/confluence/display/NUTTX/Coding+Standard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis edited a comment on pull request #3781: user correct printf specifiers
Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #3781:
URL: https://github.com/apache/incubator-nuttx/pull/3781#issuecomment-848251633
> I have others qualifiers for linux contributions but I'm not sure we want to read them here :p
>
> Are there specific rules to split string litterals or anything that fits 80 columns is okay?
Basically if you don't pass the column 78, everything is fine.
All information you need is explained here: https://cwiki.apache.org/confluence/display/NUTTX/Coding+Standard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3781: user correct printf specifiers
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3781:
URL: https://github.com/apache/incubator-nuttx/pull/3781#issuecomment-848244009
> Contributing to this project is now a nightmare.
>
> i KNOW the line is long.
>
> How do you format a long string literal like that one?
I was going to reply you, but I saw Gustavo already did it:
You can break a string line without any issue, please take a look at arch/arm/src/cxd56xx/cxd56_sfc.c
There is a finfo("blocksize: ...."
BTW, think twice if you think contributing code to NuttX is a nightmare, I have some drivers on Linux kernel and I can say NuttX is a "piece of cake" compared to Linux! ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis edited a comment on pull request #3781: use correct printf specifiers
Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #3781:
URL: https://github.com/apache/incubator-nuttx/pull/3781#issuecomment-848667698
> I have pushed a commit to fix the long line and tested my ability to use the rebase mechanism. This required a force push but thats okay.
Good, thank you!
Please squash your commits!
$ git rebase -i HEAD~2
(put squash the second commit)
$ git push -f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3781: user correct printf specifiers
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3781:
URL: https://github.com/apache/incubator-nuttx/pull/3781#issuecomment-847967484
Hi @slorquet I think you forgot to run checkpatch before submitting your PR:
$ ./tools/checkpatch.sh -f drivers/eeprom/spi_xx25xx.c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] slorquet commented on pull request #3781: user correct printf specifiers
Posted by GitBox <gi...@apache.org>.
slorquet commented on pull request #3781:
URL: https://github.com/apache/incubator-nuttx/pull/3781#issuecomment-847922576
This PR creates a printf format string that is longer than the allowed line length.
This is a test to see github CI reaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #3781: use correct printf specifiers
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #3781:
URL: https://github.com/apache/incubator-nuttx/pull/3781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] slorquet commented on pull request #3781: use correct printf specifiers
Posted by GitBox <gi...@apache.org>.
slorquet commented on pull request #3781:
URL: https://github.com/apache/incubator-nuttx/pull/3781#issuecomment-848670543
done...
what do I have to do next?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org