You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/26 04:47:56 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37657: [SPARK-40010][PYTHON][DOCS][FOLLOWUP] Make pyspark.sql.window examples self-contained (part 2)

HyukjinKwon commented on code in PR #37657:
URL: https://github.com/apache/spark/pull/37657#discussion_r955643907


##########
python/pyspark/sql/window.py:
##########
@@ -371,7 +460,7 @@ def _test() -> None:
     globs["spark"] = spark
 
     (failure_count, test_count) = doctest.testmod(
-        pyspark.sql.window, globs=globs, optionflags=doctest.NORMALIZE_WHITESPACE
+        pyspark.sql.window, globs=globs, optionflags=doctest.ELLIPSIS | doctest.NORMALIZE_WHITESPACE

Review Comment:
   ```suggestion
           pyspark.sql.window, globs=globs, optionflags=doctest.NORMALIZE_WHITESPACE
   ```



##########
python/pyspark/sql/window.py:
##########
@@ -95,6 +133,45 @@ def orderBy(*cols: Union["ColumnOrName", List["ColumnOrName_"]]) -> "WindowSpec"
         ----------
         cols : str, :class:`Column` or list
             names of columns or expressions
+

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org