You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/11/02 10:43:27 UTC
[jira] [Commented] (TAJO-1578) User configuration for pull server
port is ignored.
[ https://issues.apache.org/jira/browse/TAJO-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984976#comment-14984976 ]
ASF GitHub Bot commented on TAJO-1578:
--------------------------------------
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/820#issuecomment-152971466
+1. This patch is straightforward.
> User configuration for pull server port is ignored.
> ---------------------------------------------------
>
> Key: TAJO-1578
> URL: https://issues.apache.org/jira/browse/TAJO-1578
> Project: Tajo
> Issue Type: Bug
> Reporter: Jihoon Son
> Assignee: Dongkyu Hwangbo
> Labels: newbie
>
> See the title.
> When TajoPullServerService is initialized, it overwrites user-configured pull server port with the default value as follows.
> {code}
> ...
> @Override
> public void init(Configuration conf) {
> try {
> manageOsCache = conf.getBoolean(SHUFFLE_MANAGE_OS_CACHE,
> DEFAULT_SHUFFLE_MANAGE_OS_CACHE);
> readaheadLength = conf.getInt(SHUFFLE_READAHEAD_BYTES,
> DEFAULT_SHUFFLE_READAHEAD_BYTES);
> int workerNum = conf.getInt("tajo.shuffle.rpc.server.worker-thread-num",
> Runtime.getRuntime().availableProcessors() * 2);
> selector = RpcChannelFactory.createServerChannelFactory("TajoPullServerService", workerNum)
> .option(ChannelOption.TCP_NODELAY, true)
> .childOption(ChannelOption.ALLOCATOR, PooledByteBufAllocator.DEFAULT)
> .childOption(ChannelOption.TCP_NODELAY, true);
> localFS = new LocalFileSystem();
> conf.setInt(TajoConf.ConfVars.PULLSERVER_PORT.varname
> , TajoConf.ConfVars.PULLSERVER_PORT.defaultIntVal);
> super.init(conf);
> LOG.info("Tajo PullServer initialized: readaheadLength=" + readaheadLength);
> } catch (Throwable t) {
> LOG.error(t, t);
> }
> }
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)