You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/07/05 09:30:13 UTC

[Bug 120201] New: can't undo to set table border line style in presentation.

https://issues.apache.org/ooo/show_bug.cgi?id=120201

          Priority: P3
            Bug ID: 120201
          Assignee: ooo-issues@incubator.apache.org
           Summary: can't undo to set table border line style in
                    presentation.
          Severity: normal
        Issue Type: DEFECT
    Classification: Application
                OS: All
          Reporter: bjdujing@gmail.com
          Hardware: All
            Status: CONFIRMED
           Version: AOO 3.4.0
         Component: ui
           Product: presentation

build info:OOo-dev3.4.1-r1354891

Steps:
1.launch OO and new a presentation
2.insert a table:5 rows,5 columns
3.select the table and right click mouse to enable "Table..." and set table
property

borders:
line arrangement:set outer border and all innner lines
line style:2.5 pt
color:black

background:
Fill:color,as red

click"OK"
4."Ctrl+Z" to undo all settings

defect:
undo id not ok,can't undo set table border.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Issue 120201] No Undo for Table Cell property edits

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120201

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Armin Le Grand <Ar...@me.com> ---
Okay, done.

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.

[Issue 120201] No Undo for Table Cell property edits

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120201

--- Comment #3 from Armin Le Grand <Ar...@me.com> ---
Works as expected, preparing commit...

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.

[Bug 120201] No Undo for Table Cell property edits

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120201

Rainer Bielefeld <ra...@bielefeldundbuss.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |issues@openoffice.apache.or
                   |                            |g,
                   |                            |rainerbielefeld_ooo_qa@biel
                   |                            |efeldundbuss.de
          Component|ui                          |code
             Latest|---                         |4.1.0-beta
    Confirmation on|                            |
            Product|Impress                     |Draw
            Summary|can't undo to set table     |No Undo for Table Cell
                   |border line style in        |property edits
                   |presentation.               |

--- Comment #1 from Rainer Bielefeld <ra...@bielefeldundbuss.de> ---
(a) Still  Reproducible with server installation of "AOO 4.1.0-Beta – German UI
    / German locale - [AOO410m14(Build:9760)  -  Rev. 1573601 2014-03-03 
    17:47:48]" on German WIN7 Home Premium (64bit)", own separate user profile.
(b) Same in Draw, If you apply any table property like borders, color, ..., 
     the edit will not be added to the undo stack.
(c) Same still with LibO 4.2
(d) Was still ok with OOo 3.3.0, OOo 3.1.1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Issue 120201] No Undo for Table Cell property edits

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120201

--- Comment #5 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1581891 into trunk:
i120201 added forcing TableLayouter to take action in table undo/redo
(CellUndo)

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.

[Issue 120201] No Undo for Table Cell property edits

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120201

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Armin.Le.Grand@me.com
           Assignee|issues@openoffice.apache.or |Armin.Le.Grand@me.com
                   |g                           |
   Target Milestone|---                         |4.2.0

--- Comment #2 from Armin Le Grand <Ar...@me.com> ---
The undo action (CellUndo) already remembers and resets the settings (move the
table to see it relayouting), but executing the undo does not trigger the
needed TableLayouter::UpdateBorderLayout(). This seems necessary to get the
SvxBorderLine settings recreated in the layouter from the restored items.
Currently ActionChanged() is called which repaints the stuff which is normally
sufficient. The repaint will create the highest Primitive in it's VOC and that
is compared with the last one. Unfortunately that creation will re-use the not
yet updated stuff from the TableLayouter. This shows that it is not waterproof
that all changes to the table reset the TableLayouter, sigh. Checking if using
ReformatText will do it (it should since it calls AdjustTextFrameWidthAndHeight
on its way)...

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.