You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2020/07/18 23:17:11 UTC
Review Request 72693: RANGER-2918:Ranger Audit for HBase does not
capture predicates
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72693/
-----------------------------------------------------------
Review request for ranger, Abhay Kulkarni and Madhan Neethiraj.
Bugs: RANGER-2918
https://issues.apache.org/jira/browse/RANGER-2918
Repository: ranger
Description
-------
RANGER-2918:Ranger Audit for HBase does not capture predicates
Diffs
-----
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/HbaseConstants.java PRE-CREATION
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java c50a192
Diff: https://reviews.apache.org/r/72693/diff/1/
Testing
-------
Verified in Local vm
- Get and Scan commands have various predicates and this all will be printed in ranger audit where command Strings are stored
Thanks,
Ramesh Mani
Re: Review Request 72693: RANGER-2918:Ranger Audit for HBase does not
capture predicates
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72693/#review221267
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On July 20, 2020, 5:43 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72693/
> -----------------------------------------------------------
>
> (Updated July 20, 2020, 5:43 a.m.)
>
>
> Review request for ranger, Abhay Kulkarni and Madhan Neethiraj.
>
>
> Bugs: RANGER-2918
> https://issues.apache.org/jira/browse/RANGER-2918
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2918:Ranger Audit for HBase does not capture predicates
>
>
> Diffs
> -----
>
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/HbaseConstants.java PRE-CREATION
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java c50a192
>
>
> Diff: https://reviews.apache.org/r/72693/diff/2/
>
>
> Testing
> -------
>
> Verified in Local vm
> - Get and Scan commands have various predicates and this all will be printed in ranger audit where command Strings are stored
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 72693: RANGER-2918:Ranger Audit for HBase does not
capture predicates
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72693/
-----------------------------------------------------------
(Updated July 20, 2020, 5:43 a.m.)
Review request for ranger, Abhay Kulkarni and Madhan Neethiraj.
Changes
-------
Fixed review comments
Bugs: RANGER-2918
https://issues.apache.org/jira/browse/RANGER-2918
Repository: ranger
Description
-------
RANGER-2918:Ranger Audit for HBase does not capture predicates
Diffs (updated)
-----
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/HbaseConstants.java PRE-CREATION
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java c50a192
Diff: https://reviews.apache.org/r/72693/diff/2/
Changes: https://reviews.apache.org/r/72693/diff/1-2/
Testing
-------
Verified in Local vm
- Get and Scan commands have various predicates and this all will be printed in ranger audit where command Strings are stored
Thanks,
Ramesh Mani
Re: Review Request 72693: RANGER-2918:Ranger Audit for HBase does not
capture predicates
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72693/#review221264
-----------------------------------------------------------
Fix it, then Ship it!
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
Lines 1003 (patched)
<https://reviews.apache.org/r/72693/#comment310139>
consider movnig #1003 and #1150 into getCommandString() method, to avoid duplicates
- Madhan Neethiraj
On July 18, 2020, 11:17 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72693/
> -----------------------------------------------------------
>
> (Updated July 18, 2020, 11:17 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni and Madhan Neethiraj.
>
>
> Bugs: RANGER-2918
> https://issues.apache.org/jira/browse/RANGER-2918
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2918:Ranger Audit for HBase does not capture predicates
>
>
> Diffs
> -----
>
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/HbaseConstants.java PRE-CREATION
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java c50a192
>
>
> Diff: https://reviews.apache.org/r/72693/diff/1/
>
>
> Testing
> -------
>
> Verified in Local vm
> - Get and Scan commands have various predicates and this all will be printed in ranger audit where command Strings are stored
>
>
> Thanks,
>
> Ramesh Mani
>
>