You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/07/17 08:20:15 UTC

[GitHub] [kafka] ijuma opened a new pull request, #12413: MINOR: Upgrade to Gradle 7.5

ijuma opened a new pull request, #12413:
URL: https://github.com/apache/kafka/pull/12413

   Highlights:
   * The default Scala Zinc version was updated from 1.3.5 to 1.6.1
   * Multiple Checkstyle tasks may now run in parallel within a project
   * Support for Java 18
   * Much more responsive continuous builds on Windows and macOS
   * Improved diagnostics for dependency resolution
   
   Compatibility notes:
   
   > When running on Java 9+, Gradle no longer opens the java.base/java.util
   > and java.base/java.lang JDK modules for all Test tasks. In some cases,
   > this would cause code to pass during testing but fail at runtime.
   
   Release notes: https://docs.gradle.org/7.5/release-notes.html
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #12413: MINOR: Upgrade to Gradle 7.5

Posted by GitBox <gi...@apache.org>.

dajac commented on PR #12413:
URL: https://github.com/apache/kafka/pull/12413#issuecomment-1186486732

   The checksum does not seem to be the right one. All the builds failed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #12413: MINOR: Upgrade to Gradle 7.5

Posted by GitBox <gi...@apache.org>.

ijuma commented on PR #12413:
URL: https://github.com/apache/kafka/pull/12413#issuecomment-1193115390

   JDK 17 build passed, the others have unrelated failures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #12413: MINOR: Upgrade to Gradle 7.5

Posted by GitBox <gi...@apache.org>.

ijuma commented on PR #12413:
URL: https://github.com/apache/kafka/pull/12413#issuecomment-1186503369

   Thanks. The local build passed since it had the version cached locally. Will fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #12413: MINOR: Upgrade to Gradle 7.5

Posted by GitBox <gi...@apache.org>.

ijuma commented on PR #12413:
URL: https://github.com/apache/kafka/pull/12413#issuecomment-1198231145

   @showuon I submitted the change upstream https://github.com/gradle/gradle/pull/21393


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma merged pull request #12413: MINOR: Upgrade to Gradle 7.5

Posted by GitBox <gi...@apache.org>.

ijuma merged PR #12413:
URL: https://github.com/apache/kafka/pull/12413


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #12413: MINOR: Upgrade to Gradle 7.5

Posted by GitBox <gi...@apache.org>.

ijuma commented on PR #12413:
URL: https://github.com/apache/kafka/pull/12413#issuecomment-1195448786

   > Just curious, the latest zinc is 1.7.1 (ref: https://mvnrepository.com/artifact/org.scala-sbt/zinc), why did we only upgrade to 1.6.1? I'm fine to stick to 1.6.1 since it fixes the log4j2 security issue.
   
   Gradle 7.5 was tested with zinc 1.6.1 and I'm not sure if zinc 1.7.1 has incompatible changes with regards to Gradle. I'll do some testing regarding that, but will merge this PR in the meantime.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #12413: MINOR: Upgrade to Gradle 7.5

Posted by GitBox <gi...@apache.org>.

ijuma commented on PR #12413:
URL: https://github.com/apache/kafka/pull/12413#issuecomment-1193115461

   @omkreddy @showuon Any of you have a second to review this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on a diff in pull request #12413: MINOR: Upgrade to Gradle 7.5

Posted by GitBox <gi...@apache.org>.

showuon commented on code in PR #12413:
URL: https://github.com/apache/kafka/pull/12413#discussion_r928126295


##########
build.gradle:
##########
@@ -66,8 +66,10 @@ ext {
   if (JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_16))
     defaultJvmArgs.addAll(
       "--add-opens=java.base/java.io=ALL-UNNAMED",
+      "--add-opens=java.base/java.lang=ALL-UNNAMED",
       "--add-opens=java.base/java.nio=ALL-UNNAMED",
       "--add-opens=java.base/java.nio.file=ALL-UNNAMED",
+      "--add-opens=java.base/java.util=ALL-UNNAMED",

Review Comment:
   Nice fix for gradle 7.5!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #12413: MINOR: Upgrade to Gradle 7.5

Posted by GitBox <gi...@apache.org>.

showuon commented on PR #12413:
URL: https://github.com/apache/kafka/pull/12413#issuecomment-1195464946

   > I'll do some testing regarding that, but will merge this PR in the meantime.
   
   Sure. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org