You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/01 07:11:40 UTC
[GitHub] [cloudstack] sureshanaparti opened a new pull request #6050: Check the network access when deploying VM in Advanced Security Group.
sureshanaparti opened a new pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050
### Description
This PR checks the network access when deploying VM in Advanced Security Group.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [x] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1059167503
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1055507416
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1055256243
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1055099525
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1057664742
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1055099103
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1059166858
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1059343766
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1055506469
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1056546886
> @sureshanaparti
> can you also add my suggestion in comment [#6049 (comment)](https://github.com/apache/cloudstack/issues/6049#issuecomment-1054422439) to this PR ?
@weizhouapache the access check for VM owner already exists here.
https://github.com/apache/cloudstack/blob/85c59979f76cef39559c75000de536a9103318bc/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L1312-L1313
so, the check against caller is still required here?
https://github.com/apache/cloudstack/blob/85c59979f76cef39559c75000de536a9103318bc/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L1339-L1340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1057825407
> if there is 4.16.2.0 release, we need to backport this, right ?
> why not target to 4.16 ?
yes, may be when another minor release is needed on 4.16.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1055255560
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1055587011
@sureshanaparti
can you also add my suggestion in comment https://github.com/apache/cloudstack/issues/6049#issuecomment-1054422439 to this PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1055485338
@GabrielBrascher can you please review/test this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1057189849
Thanks for the PR @sureshanaparti!
Is this ready to review or still in Draft?
I did a few tests applying your changes and seems to be working fine.
I will be running a few more tests but wanted to double-check if there is anything left for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1059392236
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1059344302
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1056056256
<b>Trillian test result (tid-3451)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39790 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6050-t3451-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1057664970
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1057812865
> @thanks @sureshanaparti, code LGTM.
> Tested With Advanced Network + SG and now it is working as expected.
great, thanks for testing @GabrielBrascher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1057814020
> @sureshanaparti
> should this target to 4.16 ?
@weizhouapache this is targeted to 4.17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1055289232
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1059392707
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1059768123
<b>Trillian test result (tid-3496)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36085 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6050-t3496-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1056786495
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez removed a comment on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
nvazquez removed a comment on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1059166858
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1056705543
> so, the check against caller is still required here?
@sureshanaparti
then the 2nd check can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1057679967
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1057744177
@sureshanaparti
should this target to 4.16 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1057816738
>
if there is 4.16.2.0 release, we need to backport this, right ?
why not target to 4.16 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1059379411
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1057664508
> Thanks for the PR @sureshanaparti! Is this ready to review or still in Draft?
>
> I did a few tests applying your changes and seems to be working fine. I will be running a few more tests but wanted to double-check if there is anything left for the PR.
it is ready for review @GabrielBrascher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1059167503
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1059333074
Agree with @weizhouapache - let's target the fix for branch 4.16 and merge forward to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6050:
URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1055121293
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org