You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ch...@apache.org on 2026/10/04 18:01:45 UTC
(kafka) branch trunk updated: MINOR: Remove an unused parameter of handleFinishWrite (#23694)
This is an automated email from the ASF dual-hosted git repository.
chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 80b0aa04d18 MINOR: Remove an unused parameter of handleFinishWrite (#23694)
80b0aa04d18 is described below
commit 80b0aa04d18399f7a6c2ce4bef9a63aa9bc82b88
Author: Chang-Chi Hsu <ji...@gmail.com>
AuthorDate: Mon Oct 5 02:01:35 2026 +0800
MINOR: Remove an unused parameter of handleFinishWrite (#23694)
**Change:** Remove an unused parameter of handleFinishWrite in
OffsetStorageWriter.
**Reason:** The parameter `result` is never used in `handleFinishWrite`.
Reviewers: Maros Orsak <ma...@gmail.com>, Chia-Ping Tsai
<ch...@gmail.com>
---
.../java/org/apache/kafka/connect/storage/OffsetStorageWriter.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/storage/OffsetStorageWriter.java b/connect/runtime/src/main/java/org/apache/kafka/connect/storage/OffsetStorageWriter.java
index 93c4a2eaff1..3581e30851d 100644
--- a/connect/runtime/src/main/java/org/apache/kafka/connect/storage/OffsetStorageWriter.java
+++ b/connect/runtime/src/main/java/org/apache/kafka/connect/storage/OffsetStorageWriter.java
@@ -198,7 +198,7 @@ public class OffsetStorageWriter {
}
return backingStore.set(offsetsSerialized, (error, result) -> {
- boolean isCurrent = handleFinishWrite(flushId, error, result);
+ boolean isCurrent = handleFinishWrite(flushId, error);
if (isCurrent && callback != null) {
callback.onCompletion(error, result);
}
@@ -227,7 +227,7 @@ public class OffsetStorageWriter {
* Handle completion of a write. Returns true if this callback is for the current flush
* operation, false if it's for an old operation that should now be ignored.
*/
- private synchronized boolean handleFinishWrite(long flushId, Throwable error, Void result) {
+ private synchronized boolean handleFinishWrite(long flushId, Throwable error) {
// Callbacks need to be handled carefully since the flush operation may have already timed
// out and been cancelled.
if (flushId != currentFlushId)