[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #213: [YUNIKORN-478]Handle app completion at the shim side

[GitBox <gi...@apache.org>]

yangwwei commented on pull request #213:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/213#issuecomment-746628091


   hi @HuangTing-Yao  there is some issue here. First, we need to update go.mod file in order to use the latest binary from scheduler-interface repo, where we get the new `UpdateResponse#AllocationRelease`. And one more thing I forgot to mention, from the doc:
   ```
    // Released allocations, this could be either ack from scheduler when RM asks to terminate some allocations.
     // Or it could be decision made by scheduler (such as preemption or timeout).
     repeated AllocationRelease releasedAllocations = 3;
   ```
   we need to handle this differently based on the different TERMINATION_TYPE, 
   
   ```
    enum TerminationType {
       STOPPED_BY_RM = 0;          // Stopped or killed by ResourceManager (created by RM)
       TIMEOUT = 1;                // Timed out based on the executionTimeoutMilliSeconds (created by core)
       PREEMPTED_BY_SCHEDULER = 2; // Preempted allocation by scheduler (created by core)
       PLACEHOLDER_REPLACED = 3;   // Placeholder allocation replaced by real allocation (created by core)
     }
   ```
   
   if `STOPPED_BY_RM`,  there is no operation needed in the shim side (today's behavior)
   if otherwise i.e `TIMEOUT`, `PREEMPTED_BY_SCHEDULER` or `PLACEHOLDER_REPLACED`, we will need to trigger the pod delete. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org