You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/10/06 12:59:36 UTC
[GitHub] [trafficcontrol] shamrickus opened a new pull request #5109: Clear column filters when hiding column
shamrickus opened a new pull request #5109:
URL: https://github.com/apache/trafficcontrol/pull/5109
<!--
************ STOP!! ************
If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
## What does this PR (Pull Request) do?
<!-- Explain the changes you made here. If this fixes an Issue, identify it by
replacing the text in the checkbox item with the Issue number e.g.
- [x] This PR fixes #9001 OR is not related to any Issue
^ This will automatically close Issue number 9001 when the Pull Request is
merged (The '#' is important).
Be sure you check the box properly, see the "The following criteria are ALL
met by this PR" section for details.
-->
- [x] This PR is not related to any Issue <!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues -->
Currently, you can add column filters to any column in the servers table; however, when the column is hidden the filter is still applied. This changes it so hidden columns have their filters cleared.
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this
Pull Request. Also, feel free to add the name of a tool or script that is
affected but not on the list.
Additionally, if this Pull Request does NOT affect documentation, please
explain why documentation is not required. -->
- Traffic Portal
## What is the best way to verify this PR?
Run TP Integration tests
Verify hiding a column with a filter removes the filter on the servers table.
<!-- Please include here ALL the steps necessary to test your Pull Request. If
it includes tests (and most should), outline here the steps needed to run the
tests. If not, lay out the manual testing procedure and please explain why
tests are unnecessary for this Pull Request. -->
<!-- If this PR fixes a bug, please list here all of the affected versions - to
the best of your knowledge. It's also pretty helpful to include a commit hash
of where 'master' is at the time this PR is opened (if it affects master),
because what 'master' means will change over time. For example, if this PR
fixes a bug that's present in master (at commit hash '1df853c8'), in v4.0.0,
and in the current 4.0.1 Release candidate (e.g. RC1), then this list would
look like:
- master (1df853c8)
- 4.0.0
- 4.0.1 (RC1)
If you don't know what other versions might have this bug, AND don't know how
to find the commit hash of 'master', then feel free to leave this section
blank (or, preferably, delete it entirely).
-->
## The following criteria are ALL met by this PR
<!-- Check the boxes to signify that the associated statement is true. To
"check a box", replace the space inside of the square brackets with an 'x'.
e.g.
- [ x] <- Wrong
- [x ] <- Wrong
- [] <- Wrong
- [*] <- Wrong
- [x] <- Correct!
-->
- [x] This PR includes tests OR I have explained why tests are unnecessary
- [x] This PR includes documentation OR I have explained why documentation is unnecessary
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
<!-- If you would like to include any additional information on the PR for
potential reviewers please put it here.
Some examples of this would be:
- Before and after screenshots/gifs of the Traffic Portal if it is affected
- Links to other dependent Pull Requests
- References to relevant context (e.g. new/updates to dependent libraries,
mailing list records, blueprints)
Feel free to leave this section blank (or, preferably, delete it entirely).
-->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #5109: Clear column filters when hiding column
Posted by GitBox <gi...@apache.org>.
shamrickus commented on a change in pull request #5109:
URL: https://github.com/apache/trafficcontrol/pull/5109#discussion_r508724877
##########
File path: traffic_portal/app/src/common/modules/table/jobs/TableJobsController.js
##########
@@ -124,6 +124,20 @@ var TableJobsController = function(tableName, jobs, $document, $scope, $state, $
$scope.job = params.data;
$scope.$apply();
},
+ onColumnVisible: function(params) {
+ if (params.visisble){
Review comment:
No...maybe...yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on pull request #5109: Clear column filters when hiding column
Posted by GitBox <gi...@apache.org>.
shamrickus commented on pull request #5109:
URL: https://github.com/apache/trafficcontrol/pull/5109#issuecomment-713158994
Added the entry
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 merged pull request #5109: Clear column filters when hiding columns on jobs and servers tables
Posted by GitBox <gi...@apache.org>.
mitchell852 merged pull request #5109:
URL: https://github.com/apache/trafficcontrol/pull/5109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5109: Clear column filters when hiding column
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #5109:
URL: https://github.com/apache/trafficcontrol/pull/5109#discussion_r509404799
##########
File path: CHANGELOG.md
##########
@@ -82,6 +82,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Fixed #3661 - Anonymous Proxy ipv4 whitelist does not work
- Fixed #1847 - Delivery Service with SSL keys are no longer allowed to be updated when the fields changed are relevant to the SSL Keys validity.
- Fixed #5153 - Right click context menu on new ag-grid tables appearing at the wrong place after scrolling. [Related github issue](https://github.com/apache/trafficcontrol/issues/5153)
+- Fixed an issue where the jobs and servers table in Traffic Portal would not clear a columns filter when its hidden
Review comment:
because the 5.0.x branch was cut (and this did not make it), I _think_ this belongs in the `Unreleased` section which should be very tiny at this point...
But, I don't see an unreleased section yet: https://github.com/apache/trafficcontrol/blob/master/CHANGELOG.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5109: Clear column filters when hiding column
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #5109:
URL: https://github.com/apache/trafficcontrol/pull/5109#discussion_r508148438
##########
File path: traffic_portal/app/src/common/modules/table/jobs/TableJobsController.js
##########
@@ -124,6 +124,20 @@ var TableJobsController = function(tableName, jobs, $document, $scope, $state, $
$scope.job = params.data;
$scope.$apply();
},
+ onColumnVisible: function(params) {
+ if (params.visisble){
Review comment:
typo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on pull request #5109: Clear column filters when hiding column
Posted by GitBox <gi...@apache.org>.
shamrickus commented on pull request #5109:
URL: https://github.com/apache/trafficcontrol/pull/5109#issuecomment-714656278
Pushed a fix for the test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5109: Clear column filters when hiding column
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5109:
URL: https://github.com/apache/trafficcontrol/pull/5109#discussion_r510259514
##########
File path: CHANGELOG.md
##########
@@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
+## [unreleased]
+### Fixed
+- Fixed an issue where the jobs and servers table in Traffic Portal would not clear a columns filter when its hidden
Review comment:
s/columns/column's/ - possessive, not plural
s/its/it's/ - contraction, not possessive
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on pull request #5109: Clear column filters when hiding column
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on pull request #5109:
URL: https://github.com/apache/trafficcontrol/pull/5109#issuecomment-708115065
@shamrickus - can u add this to TableJobsController.js as well as that was converted to an ag-grid recently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5109: Clear column filters when hiding column
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #5109:
URL: https://github.com/apache/trafficcontrol/pull/5109#discussion_r509421804
##########
File path: CHANGELOG.md
##########
@@ -82,6 +82,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Fixed #3661 - Anonymous Proxy ipv4 whitelist does not work
- Fixed #1847 - Delivery Service with SSL keys are no longer allowed to be updated when the fields changed are relevant to the SSL Keys validity.
- Fixed #5153 - Right click context menu on new ag-grid tables appearing at the wrong place after scrolling. [Related github issue](https://github.com/apache/trafficcontrol/issues/5153)
+- Fixed an issue where the jobs and servers table in Traffic Portal would not clear a columns filter when its hidden
Review comment:
you might need to rebase this to master and when you do there will no longer be an "unreleased" section but a 5.0.0 section instead so can you create an Unreleased section and put your changelog in it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5109: Clear column filters when hiding column
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #5109:
URL: https://github.com/apache/trafficcontrol/pull/5109#discussion_r509404799
##########
File path: CHANGELOG.md
##########
@@ -82,6 +82,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Fixed #3661 - Anonymous Proxy ipv4 whitelist does not work
- Fixed #1847 - Delivery Service with SSL keys are no longer allowed to be updated when the fields changed are relevant to the SSL Keys validity.
- Fixed #5153 - Right click context menu on new ag-grid tables appearing at the wrong place after scrolling. [Related github issue](https://github.com/apache/trafficcontrol/issues/5153)
+- Fixed an issue where the jobs and servers table in Traffic Portal would not clear a columns filter when its hidden
Review comment:
because the 5.0.x branch was cut (and this did not make it), I _think_ this belongs in the `Unreleased` section which should be very tiny at this point...
But, I don't see an unreleased section yet: https://github.com/apache/trafficcontrol/blob/master/CHANGELOG.md - want to ask @ocket8888 (the 5.0 release manager) about that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #5109: Clear column filters when hiding column
Posted by GitBox <gi...@apache.org>.
shamrickus commented on a change in pull request #5109:
URL: https://github.com/apache/trafficcontrol/pull/5109#discussion_r510261200
##########
File path: CHANGELOG.md
##########
@@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
+## [unreleased]
+### Fixed
+- Fixed an issue where the jobs and servers table in Traffic Portal would not clear a columns filter when its hidden
Review comment:
I am a great englisher.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5109: Clear column filters when hiding column
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #5109:
URL: https://github.com/apache/trafficcontrol/pull/5109#discussion_r509404799
##########
File path: CHANGELOG.md
##########
@@ -82,6 +82,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Fixed #3661 - Anonymous Proxy ipv4 whitelist does not work
- Fixed #1847 - Delivery Service with SSL keys are no longer allowed to be updated when the fields changed are relevant to the SSL Keys validity.
- Fixed #5153 - Right click context menu on new ag-grid tables appearing at the wrong place after scrolling. [Related github issue](https://github.com/apache/trafficcontrol/issues/5153)
+- Fixed an issue where the jobs and servers table in Traffic Portal would not clear a columns filter when its hidden
Review comment:
because the 5.0.x branch was cut, I _think_ this belongs in the `Unreleased` section which should be very tiny at this point...
But, I don't see an unreleased section yet: https://github.com/apache/trafficcontrol/blob/master/CHANGELOG.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on pull request #5109: Clear column filters when hiding column
Posted by GitBox <gi...@apache.org>.
shamrickus commented on pull request #5109:
URL: https://github.com/apache/trafficcontrol/pull/5109#issuecomment-709561720
Didn't realize that was something you could do, will fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 edited a comment on pull request #5109: Clear column filters when hiding column
Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on pull request #5109:
URL: https://github.com/apache/trafficcontrol/pull/5109#issuecomment-709565575
> Didn't realize that was something you could do, will fix.
yeah, hidden feature @ocket8888 showed me. not sure how to get hiding a column by dragging it up to trigger `$scope.toggleVisibility`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on pull request #5109: Clear column filters when hiding column
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on pull request #5109:
URL: https://github.com/apache/trafficcontrol/pull/5109#issuecomment-709565575
> Didn't realize that was something you could do, will fix.
yeah, hidden feature Brennan showed me. not sure how to get hiding a column by dragging it up to trigger `$scope.toggleVisibility`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org