You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Lior Lipshitz (JIRA)" <ji...@apache.org> on 2012/08/15 11:58:38 UTC
[jira] [Created] (AMQ-3976) ActiveMQMessageProducer::send uses ==
instead of equals to compare destinations
Lior Lipshitz created AMQ-3976:
----------------------------------
Summary: ActiveMQMessageProducer::send uses == instead of equals to compare destinations
Key: AMQ-3976
URL: https://issues.apache.org/jira/browse/AMQ-3976
Project: ActiveMQ
Issue Type: Bug
Components: JMS client
Affects Versions: 5.5.1
Reporter: Lior Lipshitz
Priority: Minor
In method
send(Destination destination, Message message, int deliveryMode, int priority, long timeToLive)
The comparison destination == info.getDestination() in line 205 seems wrong.
I think that destination.equals(info.getDestination()).
Otherwise you get an exception "This producer can only send messages to QUEUE", even when both destination and info.getDestination() point to the same queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-3976) ActiveMQMessageProducer::send uses ==
instead of equals to compare destinations
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated AMQ-3976:
-----------------------------
Fix Version/s: 5.7.0
> ActiveMQMessageProducer::send uses == instead of equals to compare destinations
> -------------------------------------------------------------------------------
>
> Key: AMQ-3976
> URL: https://issues.apache.org/jira/browse/AMQ-3976
> Project: ActiveMQ
> Issue Type: Bug
> Components: JMS client
> Affects Versions: 5.5.1
> Reporter: Lior Lipshitz
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 5.7.0
>
>
> In method
> send(Destination destination, Message message, int deliveryMode, int priority, long timeToLive)
> The comparison destination == info.getDestination() in line 205 seems wrong.
> I think that destination.equals(info.getDestination()).
> Otherwise you get an exception "This producer can only send messages to QUEUE", even when both destination and info.getDestination() point to the same queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (AMQ-3976) ActiveMQMessageProducer::send uses ==
instead of equals to compare destinations
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned AMQ-3976:
--------------------------------
Assignee: Claus Ibsen
> ActiveMQMessageProducer::send uses == instead of equals to compare destinations
> -------------------------------------------------------------------------------
>
> Key: AMQ-3976
> URL: https://issues.apache.org/jira/browse/AMQ-3976
> Project: ActiveMQ
> Issue Type: Bug
> Components: JMS client
> Affects Versions: 5.5.1
> Reporter: Lior Lipshitz
> Assignee: Claus Ibsen
> Priority: Minor
>
> In method
> send(Destination destination, Message message, int deliveryMode, int priority, long timeToLive)
> The comparison destination == info.getDestination() in line 205 seems wrong.
> I think that destination.equals(info.getDestination()).
> Otherwise you get an exception "This producer can only send messages to QUEUE", even when both destination and info.getDestination() point to the same queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (AMQ-3976) ActiveMQMessageProducer::send uses ==
instead of equals to compare destinations
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved AMQ-3976.
------------------------------
Resolution: Fixed
Thanks for reporting.
> ActiveMQMessageProducer::send uses == instead of equals to compare destinations
> -------------------------------------------------------------------------------
>
> Key: AMQ-3976
> URL: https://issues.apache.org/jira/browse/AMQ-3976
> Project: ActiveMQ
> Issue Type: Bug
> Components: JMS client
> Affects Versions: 5.5.1
> Reporter: Lior Lipshitz
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 5.7.0
>
>
> In method
> send(Destination destination, Message message, int deliveryMode, int priority, long timeToLive)
> The comparison destination == info.getDestination() in line 205 seems wrong.
> I think that destination.equals(info.getDestination()).
> Otherwise you get an exception "This producer can only send messages to QUEUE", even when both destination and info.getDestination() point to the same queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3976) ActiveMQMessageProducer::send uses ==
instead of equals to compare destinations
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446730#comment-13446730 ]
Claus Ibsen commented on AMQ-3976:
----------------------------------
I can see the code has not changed since the initial checkin of the source.
So you are the first to report this.
Do you have an unit test or use-case that was affected by this?
> ActiveMQMessageProducer::send uses == instead of equals to compare destinations
> -------------------------------------------------------------------------------
>
> Key: AMQ-3976
> URL: https://issues.apache.org/jira/browse/AMQ-3976
> Project: ActiveMQ
> Issue Type: Bug
> Components: JMS client
> Affects Versions: 5.5.1
> Reporter: Lior Lipshitz
> Priority: Minor
>
> In method
> send(Destination destination, Message message, int deliveryMode, int priority, long timeToLive)
> The comparison destination == info.getDestination() in line 205 seems wrong.
> I think that destination.equals(info.getDestination()).
> Otherwise you get an exception "This producer can only send messages to QUEUE", even when both destination and info.getDestination() point to the same queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira