You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/12/10 18:54:57 UTC
[GitHub] [submarine] rayray2002 opened a new pull request #828: [SUBMARINE-1104]. Install Kube-Prometheus-Stack via helm
rayray2002 opened a new pull request #828:
URL: https://github.com/apache/submarine/pull/828
### What is this PR for?
Prometheus + Grafana are good data visualizing tools for k8s. Adding them to Submarine to monitor matrices and resources.
[kube-prometheus-stack](https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack) is a collection of Kubernetes, Grafana and Prometheus configurations. Easy for for setting up and monitoring.
### What type of PR is it?
[Feature]
### Todos
* [ ] - Deploy ingressroute in submarine
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1104
### How should this be tested?
```
cd subamrine
kubectl apply -f ./submarine-cloud-v2/artifacts/submarine/submarine-grafana.yaml
```
http://localhost:32080/grafana/
ID: admin
Password: prom-operator
### Screenshots (if appropriate)
<img width="1440" alt="ζͺε 2021-12-07 δΈε12 39 12" src="https://user-images.githubusercontent.com/8317457/145626567-98235ad0-0e7d-4366-bb2f-0966f21529e3.png">
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No (I think)
* Does this need new documentation? Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] KUAN-HSUN-LI commented on pull request #828: SUBMARINE-1104. Install Kube-Prometheus-Stack via helm
Posted by GitBox <gi...@apache.org>.
KUAN-HSUN-LI commented on pull request #828:
URL: https://github.com/apache/submarine/pull/828#issuecomment-1052142925
@pingsutw I will take over this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] rayray2002 commented on pull request #828: SUBMARINE-1104. Install Kube-Prometheus-Stack via helm
Posted by GitBox <gi...@apache.org>.
rayray2002 commented on pull request #828:
URL: https://github.com/apache/submarine/pull/828#issuecomment-1012818707
@KUAN-HSUN-LI
Install it by helm dependency and apply values by a yaml file.
TODO:
- [ ] Licence
- [ ] Codegen check (I don't really know why QQ)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] rayray2002 commented on pull request #828: SUBMARINE-1104. Install Kube-Prometheus-Stack via helm
Posted by GitBox <gi...@apache.org>.
rayray2002 commented on pull request #828:
URL: https://github.com/apache/submarine/pull/828#issuecomment-991233279
Some tests failed might due to k8s version difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on pull request #828: SUBMARINE-1104. Install Kube-Prometheus-Stack via helm
Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #828:
URL: https://github.com/apache/submarine/pull/828#issuecomment-991648362
Yes, we should. it's huge PR, will we use all the files in this PR? Could we remove some of the files?
you can refer to https://devopscube.com/setup-prometheus-monitoring-on-kubernetes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] rayray2002 removed a comment on pull request #828: SUBMARINE-1104. Install Kube-Prometheus-Stack via helm
Posted by GitBox <gi...@apache.org>.
rayray2002 removed a comment on pull request #828:
URL: https://github.com/apache/submarine/pull/828#issuecomment-991233279
Some tests failed might due to k8s version difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] cdmikechen commented on pull request #828: SUBMARINE-1104. Install Kube-Prometheus-Stack via helm
Posted by GitBox <gi...@apache.org>.
cdmikechen commented on pull request #828:
URL: https://github.com/apache/submarine/pull/828#issuecomment-1013580931
> @KUAN-HSUN-LI Install it by helm dependency and apply values by a yaml file. TODO:
>
> * [ ] Codegen check (I don't really know why QQ)
Maybe you need to update your codes to newest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on pull request #828: SUBMARINE-1104. Install Kube-Prometheus-Stack via helm
Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #828:
URL: https://github.com/apache/submarine/pull/828#issuecomment-991648362
Yes, we should. it's huge PR, will we use all the files in this PR? Could we remove some of the files?
you can refer to https://devopscube.com/setup-prometheus-monitoring-on-kubernetes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on pull request #828: SUBMARINE-1104. Install Kube-Prometheus-Stack via helm
Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #828:
URL: https://github.com/apache/submarine/pull/828#issuecomment-1020796748
@rayray2002 thank you, I'm going to merge this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on pull request #828: SUBMARINE-1104. Install Kube-Prometheus-Stack via helm
Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #828:
URL: https://github.com/apache/submarine/pull/828#issuecomment-1020796748
@rayray2002 thank you, I'm going to merge this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] rayray2002 edited a comment on pull request #828: SUBMARINE-1104. Install Kube-Prometheus-Stack via helm
Posted by GitBox <gi...@apache.org>.
rayray2002 edited a comment on pull request #828:
URL: https://github.com/apache/submarine/pull/828#issuecomment-1012818707
@KUAN-HSUN-LI
Install it by helm dependency and apply values by a yaml file.
TODO:
- [ ] Codegen check (I don't really know why QQ)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] rayray2002 commented on pull request #828: SUBMARINE-1104. Install Kube-Prometheus-Stack via helm
Posted by GitBox <gi...@apache.org>.
rayray2002 commented on pull request #828:
URL: https://github.com/apache/submarine/pull/828#issuecomment-991233279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] cdmikechen commented on pull request #828: SUBMARINE-1104. Install Kube-Prometheus-Stack via helm
Posted by GitBox <gi...@apache.org>.
cdmikechen commented on pull request #828:
URL: https://github.com/apache/submarine/pull/828#issuecomment-993535656
@rayray2002
I think you maybe use [helm dependency](https://helm.sh/docs/helm/helm_dependency/).
In this way, dependencies can be directly downloaded into chart for use ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #828: SUBMARINE-1104. Install Kube-Prometheus-Stack via helm
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #828:
URL: https://github.com/apache/submarine/pull/828#discussion_r786393437
##########
File path: helm-charts/submarine/install.sh
##########
@@ -0,0 +1,20 @@
+#
Review comment:
Do we really need this file? can we remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] rayray2002 removed a comment on pull request #828: SUBMARINE-1104. Install Kube-Prometheus-Stack via helm
Posted by GitBox <gi...@apache.org>.
rayray2002 removed a comment on pull request #828:
URL: https://github.com/apache/submarine/pull/828#issuecomment-991233279
Some tests failed might due to k8s version difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] rayray2002 commented on pull request #828: SUBMARINE-1104. Install Kube-Prometheus-Stack via helm
Posted by GitBox <gi...@apache.org>.
rayray2002 commented on pull request #828:
URL: https://github.com/apache/submarine/pull/828#issuecomment-991696998
> Yes, we should. it's huge PR, will we use all the files in this PR? Could we remove some of the files? you can refer to https://devopscube.com/setup-prometheus-monitoring-on-kubernetes
It is a way to install it but seems not a common way. kube-prometheus-stack is well maintained and updated, and the configs are easier to configure. Maybe I can find is there other way to pass configs in value.yaml without extracting the package, or do anyone know better solution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] rayray2002 commented on pull request #828: SUBMARINE-1104. Install Kube-Prometheus-Stack via helm
Posted by GitBox <gi...@apache.org>.
rayray2002 commented on pull request #828:
URL: https://github.com/apache/submarine/pull/828#issuecomment-991504213
Should I add license to every files in kube-prometheus-stack?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] rayray2002 commented on a change in pull request #828: SUBMARINE-1104. Install Kube-Prometheus-Stack via helm
Posted by GitBox <gi...@apache.org>.
rayray2002 commented on a change in pull request #828:
URL: https://github.com/apache/submarine/pull/828#discussion_r789312822
##########
File path: helm-charts/submarine/install.sh
##########
@@ -0,0 +1,20 @@
+#
Review comment:
No, we don't really need it. Just for install convenience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org