You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Arturo Bernal (Jira)" <ji...@apache.org> on 2023/03/29 21:11:00 UTC
[jira] [Comment Edited] (HTTPCLIENT-1368) stale-if-error request cache directive should also apply to non-revalidatable cache entries
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706602#comment-17706602 ]
Arturo Bernal edited comment on HTTPCLIENT-1368 at 3/29/23 9:10 PM:
--------------------------------------------------------------------
Hi [~olegk]
Thank you for taking the time to review my changes and providing feedback. You were right in pointing out that my initial implementation was not correct and could potentially lead to issues with the async protocol handling pipeline.
After some further research , i made the necessary changes to ensure that stale cache entries are only returned in the case of an 500 and 504 (inclusive) status when revalidating a stale cache entry. We also made sure that the changes are consistent with both the classic and async APIs.
Thank you again for your input
was (Author: arturobernalg):
Hi [~olegk]
Thank you for taking the time to review my changes and providing feedback. You were right in pointing out that my initial implementation was not correct and could potentially lead to issues with the async protocol handling pipeline.
After some further research , i made the necessary changes to ensure that stale cache entries are only returned in the case of an 500 and 504 (inclusive) status when revalidating a stale cache entry. We also made sure that the changes are consistent with both the classic and async APIs.
Thank you again for your input
> stale-if-error request cache directive should also apply to non-revalidatable cache entries
> -------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1368
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1368
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpCache
> Affects Versions: 4.2.4, 4.2.5, 4.3 Beta1
> Reporter: Jonathan Moore
> Priority: Minor
> Labels: stuck, volunteers-wanted
> Fix For: Stuck
>
>
> The stale-if-error request cache directive is defined in RFC 5861:
> http://tools.ietf.org/html/rfc5861
> As implemented, this will only apply to cache entries that are revalidatable (i.e. they have an Etag or Last-Modified header and can be refreshed with a conditional request) but it should also apply to any stale cache entry.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org