You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@abdera.apache.org by Garrett Rooney <ro...@electricjellyfish.net> on 2006/06/18 03:51:32 UTC

[PATCH] Pull dependencies out of build.xml into properties file

The "download" target in build.xml seemed kind of ugly, duplicating
the filenames in both the urls and destinations because the <get> task
can't be told to drop files in a directory, and cluttering up
build.xml with giant urls.  So, I pulled the urls and filenames out
into a properties file and made the <get> tasks use them instead of
hardcoding things.  At the very least it removes some duplication in
the filenames and cleans things up a little bit.

Still on the TODO list is making download run automatically if any of
the dependencies aren't present...

-garrett

[[[
Pull urls and filenames out of build.xml into a properties file.

* build/build.xml
  Pull properties from dependencies/deps.properties.
  (download): Use new properties.

* dependencies/deps.properties: New file.
]]]

Re: [PATCH] Pull dependencies out of build.xml into properties file

Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 6/17/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> The "download" target in build.xml seemed kind of ugly, duplicating
> the filenames in both the urls and destinations because the <get> task
> can't be told to drop files in a directory, and cluttering up
> build.xml with giant urls.  So, I pulled the urls and filenames out
> into a properties file and made the <get> tasks use them instead of
> hardcoding things.  At the very least it removes some duplication in
> the filenames and cleans things up a little bit.
>
> Still on the TODO list is making download run automatically if any of
> the dependencies aren't present...

Ok, I got motivated.  Here's a version of the patch that makes us
automatically pull down the dependencies if they're not present.

-garrett

[[[
Pull urls and filenames out of build.xml into a properties file, grab
the dependencies before building if they're not already present.

* build/build.xml
  Pull properties from dependencies/deps.properties.
  (download): Use new properties, add an if attribute.
  (init): Set do.download if any dependencies are missing.

* dependencies/deps.properties: New file.
]]]