Re: [Apache Bloodhound] #359: Highlight field values in ticket comments feed

[Apache Bloodhound <de...@bloodhound.apache.org>]

#359: Highlight field values in ticket comments feed
--------------------------+------------------------------------------
  Reporter:  olemis       |      Owner:  nobody
      Type:  enhancement  |     Status:  new
  Priority:  trivial      |  Milestone:
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  ticket comments diff starter
--------------------------+------------------------------------------

Comment (by mudri):

 I'm having a problem with this. After editing bh_ticket_change.html and
 the CSS file, highlighting works only for:
 * Component
 * Status
 * Milestone
 * Priority
 * Summary
 * Type
 * Version
 And not:
 * Owner
 * Reporter
 * CC
 * Keywords
 Is there a difference between how these two groups are handled? No change
 in bh_ticket_change.html makes a difference to displaying the latter
 fields.

 Anyway, here are the changes so far:
 {{{
 #!xml
 Index: bloodhound_theme/bhtheme/templates/bh_ticket_change.html
 ===================================================================
 --- bloodhound_theme/bhtheme/templates/bh_ticket_change.html    (revision
 1505634)
 +++ bloodhound_theme/bhtheme/templates/bh_ticket_change.html    (working
 copy)
 @@ -147,20 +147,20 @@
            <py:when test="field_name == 'reported'">
            </py:when>
            <py:when test="field_name == 'attachment'"><i18n:msg
 params="name">
 -            <a href="${href.attachment('ticket', ticket.id,
 field.new)}"><em>${field.new
 +            <a href="${href.attachment('ticket', ticket.id,
 field.new)}"><em class="new-value">${field.new
                }</em></a><a href="${href('raw-attachment', 'ticket',
 ticket.id, field.new)}"
                             title="Download" class="trac-
 rawlink">&#8203;</a>
              added
            </i18n:msg></py:when>
            <py:when test="'rendered' in field">${field.rendered}</py:when>
            <py:when test="field.old and field.new"><i18n:msg params="old,
 new">
 -            changed from <em>${field.old}</em> to <em>${field.new}</em>
 +            changed from <em class="old-value">${field.old}</em> to <em
 class="new-value">${field.new}</em>
            </i18n:msg></py:when>
            <py:when test="not field.old and field.new"><i18n:msg
 params="value">
 -            set to <em>${field.new}</em>
 +            set to <em class="new-value">${field.new}</em>
            </i18n:msg></py:when>
            <py:otherwise><i18n:msg params="value">
 -            <em>${field.old}</em> deleted
 +            <em class="old-value">${field.old}</em> deleted
            </i18n:msg></py:otherwise>
          </py:choose>
          <span class="${'hidden-desktop' if change.cnum else ''}">
 }}}
 {{{
 #!css
 Index: bloodhound_theme/bhtheme/htdocs/bloodhound.css
 ===================================================================
 --- bloodhound_theme/bhtheme/htdocs/bloodhound.css      (revision 1505634)
 +++ bloodhound_theme/bhtheme/htdocs/bloodhound.css      (working copy)
 @@ -1281,3 +1281,16 @@
  input[type="radio"]:not(:checked) + label span {
   text-decoration:underline;
  }
 +
 +#content textarea,
 +.popover-content textarea {
 + font-family: monospace;
 +}
 +
 +.old-value {
 + background: #FCE9E9;
 +}
 +
 +.new-value {
 + background: #E7FDE7;
 +}
 }}}

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/359#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker