[GitHub] junichi11 edited a comment on issue #658: [NETBEANS-1074] Licensing 105 unlicensed xml files listed in rat-report

[GitBox <gi...@apache.org>]

junichi11 edited a comment on issue #658: [NETBEANS-1074] Licensing 105 unlicensed xml files listed in rat-report
URL: https://github.com/apache/incubator-netbeans/pull/658#issuecomment-411715779
 
 
   > ant -> success
   > ant tryme -> success
   > ant rat -> following failures
   
   @thilina01 I don't mean these. 
   e.g. 
   `web.jsf/test/unit/src/org/netbeans/modules/web/jsf/refactoring/data/goldenfiles/ModificationsTest/gold-modifications.xml`
   This file is used in 
   `web.jsf/test/unit/src/org/netbeans/modules/web/jsf/refactoring/ModificationsTest.java`.
   I meant that open the web.jsf module in NetBeans, then right-click ModificationsTest.java, run Test File.
   
   In this case, if you add the license header, test fails. So we don't have to add the license header. Instead, we have to add the file to rat-exclusions.txt.
   
   I suggest you should check modules[1] one by one because this PR may be a cause of confusion...
   Please also look at [2] and PRs of the 1st review e.g. #26 e.t.c. 
   [1] https://cwiki.apache.org/confluence/display/NETBEANS/2nd+Donation%3A+List+of+Modules+to+Review
   [2] https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists