You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2020/12/02 08:20:12 UTC
svn commit: r1884011 - in
/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox:
TestValidatePermitedMetadata.java TestXMPWithDefinedSchemas.java
schema/BasicJobTicketSchemaTest.java schema/XMPSchemaTest.java
type/AttributeTest.java
Author: msahyoun
Date: Wed Dec 2 08:20:11 2020
New Revision: 1884011
URL: http://svn.apache.org/viewvc?rev=1884011&view=rev
Log:
PDFBOX-4892: Sonar fixes
Modified:
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestValidatePermitedMetadata.java
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/BasicJobTicketSchemaTest.java
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/XMPSchemaTest.java
pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/AttributeTest.java
Modified: pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestValidatePermitedMetadata.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestValidatePermitedMetadata.java?rev=1884011&r1=1884010&r2=1884011&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestValidatePermitedMetadata.java (original)
+++ pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestValidatePermitedMetadata.java Wed Dec 2 08:20:11 2020
@@ -44,7 +44,7 @@ import java.util.List;
class TestValidatePermitedMetadata
{
- public static Collection<Object[]> initializeParameters() throws Exception
+ static Collection<Object[]> initializeParameters() throws Exception
{
List<Object[]> params = new ArrayList<>();
InputStream is = TestValidatePermitedMetadata.class.getResourceAsStream("/permited_metadata.txt");
@@ -70,7 +70,7 @@ class TestValidatePermitedMetadata
@ParameterizedTest
@MethodSource("initializeParameters")
- public void checkExistence(String namespace, String preferred, String fieldname) throws Exception
+ void checkExistence(String namespace, String preferred, String fieldname) throws Exception
{
// ensure schema exists
XMPMetadata xmpmd = new XMPMetadata();
Modified: pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java?rev=1884011&r1=1884010&r2=1884011&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java (original)
+++ pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java Wed Dec 2 08:20:11 2020
@@ -21,6 +21,8 @@
package org.apache.xmpbox;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
import java.io.InputStream;
import java.util.stream.Stream;
@@ -49,5 +51,7 @@ class TestXMPWithDefinedSchemas
DomXmpParser builder = new DomXmpParser();
XMPMetadata rxmp = builder.parse(is);
+ // ensure basic parsing was OK
+ assertTrue(rxmp.getAllSchemas().size()>0);
}
}
Modified: pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/BasicJobTicketSchemaTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/BasicJobTicketSchemaTest.java?rev=1884011&r1=1884010&r2=1884011&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/BasicJobTicketSchemaTest.java (original)
+++ pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/BasicJobTicketSchemaTest.java Wed Dec 2 08:20:11 2020
@@ -27,7 +27,6 @@ import java.io.ByteArrayOutputStream;
import org.apache.xmpbox.XMPMetadata;
import org.apache.xmpbox.type.JobType;
-import org.apache.xmpbox.type.StructuredType;
import org.apache.xmpbox.xml.DomXmpParser;
import org.apache.xmpbox.xml.XmpSerializer;
import org.junit.jupiter.api.Test;
@@ -78,16 +77,11 @@ class BasicJobTicketSchemaTest
XMPBasicJobTicketSchema jt = rxmp.getBasicJobTicketSchema();
assertNotNull(jt);
assertEquals(1, jt.getJobs().size());
- StructuredType stjob = JobType.class.getAnnotation(StructuredType.class);
JobType job = jt.getJobs().get(0);
assertEquals("zeid2", job.getId());
assertEquals("zename2", job.getName());
assertEquals("zeurl2", job.getUrl());
- // assertEquals("Invalid namespace",stjob.namespace(),
- // job.getNamespace());
- // assertEquals(stjob.preferedPrefix(), job.getPrefix());
-
}
@Test
Modified: pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/XMPSchemaTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/XMPSchemaTest.java?rev=1884011&r1=1884010&r2=1884011&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/XMPSchemaTest.java (original)
+++ pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/schema/XMPSchemaTest.java Wed Dec 2 08:20:11 2020
@@ -384,9 +384,7 @@ class XMPSchemaTest
{
String bagName = "bagName";
String seqName = "seqName";
- String qseqName = "test:" + seqName;
String altName = "AltProp";
- String qaltName = "test:" + altName;
String valBagSchem1 = "BagvalSchem1";
String valBagSchem2 = "BagvalSchem2";
Modified: pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/AttributeTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/AttributeTest.java?rev=1884011&r1=1884010&r2=1884011&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/AttributeTest.java (original)
+++ pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/type/AttributeTest.java Wed Dec 2 08:20:11 2020
@@ -32,7 +32,6 @@ class AttributeTest
void testAtt()
{
String nsUri = "nsUri";
- String prefix = "prefix";
String localName = "localName";
String value = "value";
@@ -43,7 +42,6 @@ class AttributeTest
assertEquals(value, att.getValue());
String nsUri2 = "nsUri2";
- String prefix2 = "prefix2";
String localName2 = "localName2";
String value2 = "value2";