You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Myrna van Lunteren (JIRA)" <ji...@apache.org> on 2008/10/09 23:24:44 UTC

[jira] Commented: (DERBY-3902) some messages are referenced but never used - MessageBundleTest output

    [ https://issues.apache.org/jira/browse/DERBY-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638399#action_12638399 ] 

Myrna van Lunteren commented on DERBY-3902:
-------------------------------------------

With revision 703170 for DERBY-1411 removed the X0RQ3 unused sqlstate.
With revision 703259 I corrected the SQLState reference in messages.xml & all translated .properties files for 22003.S.4 / 22004.S.4 - should've been 2004.S.4 both in SQLState.java & messages.xml (originally messages_en.properties) (See also a comment in DERBY-1567).
I also fixed up the MessageBundleTest to ignore SQLStates XCL32 and XSAX1, which aren't exposed to end users and so do not need text. (See also DERBY-1414 and DERBY-1413).



> some messages are referenced but never used - MessageBundleTest output
> ----------------------------------------------------------------------
>
>                 Key: DERBY-3902
>                 URL: https://issues.apache.org/jira/browse/DERBY-3902
>             Project: Derby
>          Issue Type: Bug
>    Affects Versions: 10.5.0.0
>            Reporter: Myrna van Lunteren
>
> MessageBundleTest was taken out of derbyall because it only ran with classes, not with jars, and it was decided that it would be better to make this into a build check rather than a test...
> However, the build check - DERBY-1458 - was never implemented, and so, the test has not been run.
> When I ran, I got the following output:
> testSQLStateOrphanedIds ERROR: Message id 22003.S.4 in SQLState.java was not found in messages_en.properties
> ERROR: Message id XCL32.S in SQLState.java was not found in messages_en.properties
> ERROR: Message id X0RQ3.C in SQLState.java was not found in messages_en.properties
> ERROR: Message id XSAX1 in SQLState.java was not found in messages_en.properties
> used 188 ms .
> testMessageIdOrphanedIds used 0 ms .
> testMessageBundleOrphanedMessages WARNING: Message id 22004.S.4 in messages_en.properties is not referenced in either SQLState.java or MessageId.java
> WARNING: Message id J106 in messages_en.properties is not referenced in either SQLState.java or MessageId.java
> WARNING: Message id J107 in messages_en.properties is not referenced in either SQLState.java or MessageId.java
> WARNING: Message id J108 in messages_en.properties is not referenced in either SQLState.java or MessageId.java
> WARNING: Message id J109 in messages_en.properties is not referenced in either SQLState.java or MessageId.java
> WARNING: Message id 08000.S.1 in messages_en.properties is not referenced in either SQLState.java or MessageId.java
> WARNING: Message id XCL17.S in messages_en.properties is not referenced in either SQLState.java or MessageId.java
> WARNING: Message id XJ102.S in messages_en.properties is not referenced in either SQLState.java or MessageId.java
> used 0 ms 
> Some of these are known issues, e.g. XCL32 - it's been in MessageBundleTest.out for a long time...
> XSAX1 looks like a assumption mismatch in MessageBundleTest, see DERBY-1413....
> But others need some minor code changes/cleanup, for instance, looks like the need for J106 was removed during DERBY-2692, see http://svn.apache.org/viewvc?view=rev&revision=543428, and should probably get removed from messages_en.properties/messages.xml.
> Needs further checking.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.