[jira] [Closed] (CALCITE-4320) JdbcRules JOIN_FACTORY, AGGREGATE_FACTORY, SET_OP_FACTORY, ... create relations with wrong convention

["Vladimir Sitnikov (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Sitnikov closed CALCITE-4320.
--------------------------------------
    Resolution: Abandoned

> JdbcRules JOIN_FACTORY, AGGREGATE_FACTORY, SET_OP_FACTORY, ... create relations with wrong convention
> -----------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-4320
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4320
>             Project: Calcite
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 1.26.0
>            Reporter: Vladimir Sitnikov
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> {code:java}
>   static final RelFactories.JoinFactory JOIN_FACTORY =
>       (left, right, hints, condition, variablesSet, joinType, semiJoinDone) -> {
>         final RelOptCluster cluster = left.getCluster();
>         final RelTraitSet traitSet = cluster.traitSetOf(left.getConvention());
>         try {
>           return new JdbcJoin(cluster, traitSet, left, right, condition,
>               variablesSet, joinType);
> {code}
> In practice, JdbcJoin should use JdbcConvention rather than {{cluster.traitSetOf(left.getConvention());}}
> I wonder if RelFactories in JdbcRules are dead code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)