[GitHub] [hbase] gjacoby126 commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend

[GitBox <gi...@apache.org>]

gjacoby126 commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
URL: https://github.com/apache/hbase/pull/390#issuecomment-517757619
 
 
   @apurtell @anoopsjohn - The currently posted version of this PR incorporates @anoopsjohn 's feedback for adding an addExtendedAttributes method to WALKey rather than allowing the coprocessor to create and return a new WALKeyImpl. The last run of Yetus should have been a +1, because the only thing that failed was a timeout tearing down a test. 
   
   I have not yet incorporated @apurtell 's suggestion to add WALEdit to the coprocessor hook, because of the InterfaceAudience.Private notations on WALEdit.add and the seemingly deliberate decision to exclude WALEdit from any coprocessor that could alter it before committing to the WAL. 
   
   I personally don't see an issue with adding WALEdit to the coproc (if it's OK to write a coproc that adds a column to every Put, why not a coproc that adds a Cell to every WALEdit?), but it's not necessary for my purposes, and I don't want to add it in just to find out that I need to take it out after all. I assume either the restriction's there for a reason I don't understand, or I misunderstand the restriction.   
   
   Please advise, and thanks for the feedback. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services