You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Giacomo Pati <gi...@apache.org> on 2006/11/09 15:59:29 UTC

[PATCH] Re: [jci] splitting FilesystemAlterationMonitor

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

For simplicity, here's the patch

Giacomo Pati wrote:
> 
> 
> Torsten Curdt wrote:
>>> Hi all (but probably mainly to Thorsten :-)
>> ;)
> 
>>> I'd like to reuse the FilesystemAlterationMonitor but without the
>>> Runnable logic in it.
>>>
>>> Couldn't we separate the monitoring process from the looping part, so
>>> that the filesystem observation logic could be used lets say with Quartz
>>> to trigger it?
>> Sure ...sounds good
> 
>>> I'd would happily donate a patch for it :-)
>> I'd be happy to accept it :)
> 
> Do you want a Jira entry for the patch?
> 
> I've called the splitted class FilesystemAlterationObserver (the one
> containing the observation code, and yes, any better naming suggestion
> welcome) and left the the FilesystemAlterationMonitor just with the
> Runnable logic.
> 
> All test run through as before (there was one which failed, and still
> failes after refactoring, so I guess it still does what was expected :-).
> 
> Is there any reason to use commons-collection 3.1 over 3.2? 3.1 has
> deprecated MultiHashMap, so I've upgraded to 3.2 and replaced it with
> the suggested MultiValueMap.
> 
> Ciao
> 
>> cheers
>> -- 
>> Torsten
> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 
> 

- ---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


- --
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFU0JRLNdJvZjjVZARAuahAKDDvzTmYW6K9IU/jgRfTBtbJp+ZIACfTs9c
+Dl6SKOb75ipijP5eMfOeS8=
=rgqL
-----END PGP SIGNATURE-----