[GitHub] [activemq-artemis] meierhofer08 commented on a change in pull request #3498: ARTEMIS-2870: Transfer connection close/failure listeners one by one …

[GitBox <gi...@apache.org>]

meierhofer08 commented on a change in pull request #3498:
URL: https://github.com/apache/activemq-artemis/pull/3498#discussion_r597450847



##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/ReattachTest.java
##########
@@ -133,18 +134,31 @@ public void testReattachTransferConnectionOnSession() throws Exception {
       locator.setRetryInterval(retryInterval).setRetryIntervalMultiplier(retryMultiplier).setReconnectAttempts(reconnectAttempts).setConfirmationWindowSize(1024 * 1024);
       ClientSessionFactoryInternal sf = (ClientSessionFactoryInternal) createSessionFactory(locator);
       ClientSession session = sf.createSession(false, true, true);
+      ClientSession secondSession = sf.createSession(false, true, true);

Review comment:
       Ah ok, a separate test also makes sense, I wasn't sure as they both effectively test "transferConnection" in "ServerSessionImpl".
   Thank you for checking and merging so quickly!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org