You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/29 05:54:09 UTC

[GitHub] [incubator-superset] nytai opened a new pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

nytai opened a new pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   - Remove unnecessary scrollbars - vertical and horizontal scrollbars should only appear when they are required.
   - Table controls should be outside of the white box in the table in the grey area between the global navigation and the white box on the table.
   - On bulk select: show DELETE as a destructive red button with white text
   - Remove thick grey horizontal line below column headers
   - Remove unnecessary bottom padding on table so the scroll bar goes to the bottom of the white container
   
   #### Dashboard
   - Make the “Name” column variable width and the other columns fixed width
   - Change the “Published” column with a checkbox to “Status” with either “Published” or “Draft” for the on/off states
   - Change filter name from “Published” to “Status”
   - Add tooltips for the action icons (Delete, Export, Edit)
   - Move the “Owners” column to second from the right, immediately before Actions
   - Add "+ Dashboard" button
   - “Add <Object>” button in the sub-header should have 16px of margin on the right to line up with the right edge of the table view’s box
   
   #### Chart
   - Make “Chart” (name) variable width, all other columns fixed width
   - Add “New Chart” button next to bulk select button (to the right of Bulk Select)
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   I'll take screenshots tomorrow. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io commented on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `5.61%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   59.96%   -5.62%     
   ==========================================
     Files         828      392     -436     
     Lines       39162    24558   -14604     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        25681    14725   -10956     
   + Misses      13371     9833    -3538     
   + Partials      110        0     -110     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `59.96% <ø> (-0.99%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.38% <0.00%> (-7.98%)` | :arrow_down: |
   | [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
   | [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `94.77% <0.00%> (-5.23%)` | :arrow_down: |
   | ... and [454 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...e7cef06](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `5.22%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   60.34%   -5.23%     
   ==========================================
     Files         828      392     -436     
     Lines       39162    24574   -14588     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        25681    14830   -10851     
   + Misses      13371     9744    -3627     
   + Partials      110        0     -110     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.34% <ø> (-0.60%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.70% <0.00%> (-0.14%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <0.00%> (ø)` | |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.56% <0.00%> (ø)` | |
   | [...set-frontend/src/components/ListViewCard/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9MaXN0Vmlld0NhcmQvaW5kZXgudHN4) | | |
   | ... and [442 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...f4bc38c](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `5.60%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   59.96%   -5.61%     
   ==========================================
     Files         828      392     -436     
     Lines       39162    24563   -14599     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        25681    14730   -10951     
   + Misses      13371     9833    -3538     
   + Partials      110        0     -110     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `59.96% <ø> (-0.98%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.38% <0.00%> (-7.98%)` | :arrow_down: |
   | [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
   | [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `94.77% <0.00%> (-5.23%)` | :arrow_down: |
   | ... and [455 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...f4bc38c](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `4.09%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   61.48%   -4.10%     
   ==========================================
     Files         828      828              
     Lines       39162    39173      +11     
     Branches     3694     3690       -4     
   ==========================================
   - Hits        25681    24085    -1596     
   - Misses      13371    14907    +1536     
   - Partials      110      181      +71     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.28% <ø> (-0.02%)` | :arrow_down: |
   | #python | `61.00% <ø> (+0.06%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ator-superset/superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tor-superset/superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...superset/superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2luZGV4LmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...uperset/superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBDb2xvcnMuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY2hhcnQvQ2hhcnRDb250YWluZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBGb3JtYXR0ZXJzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et/superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9yZWR1Y2Vycy9pbmRleC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...t/superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBQbHVnaW5zRXh0cmEuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [179 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...0575175](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `4.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   61.49%   -4.09%     
   ==========================================
     Files         828      828              
     Lines       39162    39175      +13     
     Branches     3694     3691       -3     
   ==========================================
   - Hits        25681    24090    -1591     
   - Misses      13371    14904    +1533     
   - Partials      110      181      +71     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.28% <ø> (-0.02%)` | :arrow_down: |
   | #python | `61.01% <ø> (+0.07%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ator-superset/superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tor-superset/superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...superset/superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2luZGV4LmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...uperset/superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBDb2xvcnMuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY2hhcnQvQ2hhcnRDb250YWluZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBGb3JtYXR0ZXJzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et/superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9yZWR1Y2Vycy9pbmRleC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...t/superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBQbHVnaW5zRXh0cmEuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [178 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...0575175](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `4.55%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   61.02%   -4.56%     
   ==========================================
     Files         828      392     -436     
     Lines       39162    24574   -14588     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        25681    14996   -10685     
   + Misses      13371     9578    -3793     
   + Partials      110        0     -110     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.02% <ø> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <0.00%> (ø)` | |
   | [...rset/superset-frontend/src/explore/controlUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb250cm9sVXRpbHMuanM=) | | |
   | [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2FjdGlvbnMvZGF0YXNvdXJjZXMuanM=) | | |
   | [.../incubator-superset/superset-frontend/src/theme.ts](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvdGhlbWUudHM=) | | |
   | [.../superset-frontend/src/messageToasts/propShapes.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvbWVzc2FnZVRvYXN0cy9wcm9wU2hhcGVzLmpz) | | |
   | [...-frontend/src/components/Button/Button.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9CdXR0b24vQnV0dG9uLnN0b3JpZXMuanN4) | | |
   | [.../src/dashboard/util/serializeActiveFilterValues.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvc2VyaWFsaXplQWN0aXZlRmlsdGVyVmFsdWVzLmpz) | | |
   | [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL2NvbnRyb2xzL1RleHRDb250cm9sLnRzeA==) | | |
   | [...rset-frontend/src/explore/controlPanels/DeckArc.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb250cm9sUGFuZWxzL0RlY2tBcmMuanM=) | | |
   | ... and [436 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...f4bc38c](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `4.34%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   61.22%   -4.35%     
   ==========================================
     Files         828      828              
     Lines       39162    39175      +13     
     Branches     3694     3691       -3     
   ==========================================
   - Hits        25681    23986    -1695     
   - Misses      13371    15008    +1637     
   - Partials      110      181      +71     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.29% <ø> (-0.01%)` | :arrow_down: |
   | #python | `60.59% <ø> (-0.36%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ator-superset/superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tor-superset/superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...superset/superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2luZGV4LmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...uperset/superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBDb2xvcnMuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY2hhcnQvQ2hhcnRDb250YWluZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBGb3JtYXR0ZXJzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et/superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9yZWR1Y2Vycy9pbmRleC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...t/superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBQbHVnaW5zRXh0cmEuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [181 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...2993bd5](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai merged pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

nytai merged pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

nytai commented on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-701062588


   This PR is currently on hold pending some revisions by design. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `4.54%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   61.02%   -4.55%     
   ==========================================
     Files         828      392     -436     
     Lines       39162    24574   -14588     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        25681    14997   -10684     
   + Misses      13371     9577    -3794     
   + Partials      110        0     -110     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.02% <ø> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <0.00%> (ø)` | |
   | [...set-frontend/src/dashboard/util/injectCustomCss.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvaW5qZWN0Q3VzdG9tQ3NzLmpz) | | |
   | [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3JlZHVjZXJzL2Rhc2hib2FyZFN0YXRlLmpz) | | |
   | [...et/superset-frontend/src/views/CRUD/data/common.ts](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvdmlld3MvQ1JVRC9kYXRhL2NvbW1vbi50cw==) | | |
   | [...-frontend/src/dashboard/util/headerStyleOptions.ts](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvaGVhZGVyU3R5bGVPcHRpb25zLnRz) | | |
   | [...c/visualizations/TimeTable/TimeTableChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvdmlzdWFsaXphdGlvbnMvVGltZVRhYmxlL1RpbWVUYWJsZUNoYXJ0UGx1Z2luLmpz) | | |
   | [...erset-frontend/src/profile/components/UserInfo.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvcHJvZmlsZS9jb21wb25lbnRzL1VzZXJJbmZvLnRzeA==) | | |
   | [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvcHJvcFNoYXBlcy5qc3g=) | | |
   | [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | | |
   | [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvZmlsdGVyc2NvcGUvRmlsdGVyRmllbGRUcmVlLmpzeA==) | | |
   | ... and [435 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...f4bc38c](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `5.61%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   59.96%   -5.62%     
   ==========================================
     Files         828      392     -436     
     Lines       39162    24558   -14604     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        25681    14725   -10956     
   + Misses      13371     9833    -3538     
   + Partials      110        0     -110     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `59.96% <ø> (-0.99%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.38% <0.00%> (-7.98%)` | :arrow_down: |
   | [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
   | [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `94.77% <0.00%> (-5.23%)` | :arrow_down: |
   | ... and [454 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...2993bd5](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai closed pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

nytai closed pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `4.50%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   61.06%   -4.51%     
   ==========================================
     Files         828      828              
     Lines       39162    39175      +13     
     Branches     3694     3691       -3     
   ==========================================
   - Hits        25681    23923    -1758     
   - Misses      13371    15071    +1700     
   - Partials      110      181      +71     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.28% <ø> (-0.02%)` | :arrow_down: |
   | #python | `60.34% <ø> (-0.61%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ator-superset/superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tor-superset/superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...superset/superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2luZGV4LmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...uperset/superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBDb2xvcnMuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY2hhcnQvQ2hhcnRDb250YWluZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBGb3JtYXR0ZXJzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et/superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9yZWR1Y2Vycy9pbmRleC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...t/superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBQbHVnaW5zRXh0cmEuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [185 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...0575175](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `4.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   61.37%   -4.20%     
   ==========================================
     Files         828      828              
     Lines       39162    39173      +11     
     Branches     3694     3690       -4     
   ==========================================
   - Hits        25681    24043    -1638     
   - Misses      13371    14949    +1578     
   - Partials      110      181      +71     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.28% <ø> (-0.02%)` | :arrow_down: |
   | #python | `60.83% <ø> (-0.11%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ator-superset/superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tor-superset/superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...superset/superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2luZGV4LmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...uperset/superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBDb2xvcnMuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY2hhcnQvQ2hhcnRDb250YWluZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBGb3JtYXR0ZXJzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et/superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9yZWR1Y2Vycy9pbmRleC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...t/superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBQbHVnaW5zRXh0cmEuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [182 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...e7cef06](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `5.23%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   60.34%   -5.24%     
   ==========================================
     Files         828      392     -436     
     Lines       39162    24569   -14593     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        25681    14825   -10856     
   + Misses      13371     9744    -3627     
   + Partials      110        0     -110     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.34% <ø> (-0.61%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.70% <0.00%> (-0.14%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.56% <0.00%> (ø)` | |
   | [...ntend/src/dashboard/util/activeDashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvYWN0aXZlRGFzaGJvYXJkRmlsdGVycy5qcw==) | | |
   | [...et-frontend/src/dashboard/util/isDashboardEmpty.ts](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvaXNEYXNoYm9hcmRFbXB0eS50cw==) | | |
   | ... and [440 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...e7cef06](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `4.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   61.49%   -4.09%     
   ==========================================
     Files         828      828              
     Lines       39162    39175      +13     
     Branches     3694     3691       -3     
   ==========================================
   - Hits        25681    24090    -1591     
   - Misses      13371    14904    +1533     
   - Partials      110      181      +71     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.28% <ø> (-0.02%)` | :arrow_down: |
   | #python | `61.01% <ø> (+0.07%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ator-superset/superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tor-superset/superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...superset/superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2luZGV4LmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...uperset/superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBDb2xvcnMuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY2hhcnQvQ2hhcnRDb250YWluZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBGb3JtYXR0ZXJzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et/superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9yZWR1Y2Vycy9pbmRleC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...t/superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBQbHVnaW5zRXh0cmEuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [178 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...0575175](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `4.50%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   61.06%   -4.51%     
   ==========================================
     Files         828      828              
     Lines       39162    39175      +13     
     Branches     3694     3691       -3     
   ==========================================
   - Hits        25681    23924    -1757     
   - Misses      13371    15070    +1699     
   - Partials      110      181      +71     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.29% <ø> (-0.01%)` | :arrow_down: |
   | #python | `60.34% <ø> (-0.61%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ator-superset/superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tor-superset/superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...superset/superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2luZGV4LmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...uperset/superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBDb2xvcnMuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY2hhcnQvQ2hhcnRDb250YWluZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBGb3JtYXR0ZXJzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et/superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9yZWR1Y2Vycy9pbmRleC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...t/superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBQbHVnaW5zRXh0cmEuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [185 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...2993bd5](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] lilykuang commented on a change in pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

lilykuang commented on a change in pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#discussion_r502573923



##########
File path: superset-frontend/src/components/ListView/ListView.tsx
##########
@@ -267,29 +274,38 @@ function ListView<T extends object = any>({
     cardViewEnabled ? defaultViewMode : 'table',
   );
 
+  useEffect(() => {
+    // discard selections if bulk select is disabled
+    if (!bulkSelectEnabled) toggleAllRowsSelected(false);
+  }, [bulkSelectEnabled, toggleAllRowsSelected]);
+

Review comment:
       Nice




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `4.53%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   61.03%   -4.54%     
   ==========================================
     Files         828      828              
     Lines       39162    39175      +13     
     Branches     3694     3691       -3     
   ==========================================
   - Hits        25681    23911    -1770     
   - Misses      13371    15083    +1712     
   - Partials      110      181      +71     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.29% <ø> (-0.01%)` | :arrow_down: |
   | #python | `60.28% <ø> (-0.66%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ator-superset/superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tor-superset/superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...superset/superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2luZGV4LmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...uperset/superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBDb2xvcnMuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY2hhcnQvQ2hhcnRDb250YWluZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBGb3JtYXR0ZXJzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et/superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9yZWR1Y2Vycy9pbmRleC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...t/superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBQbHVnaW5zRXh0cmEuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [183 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...2993bd5](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `5.23%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   60.34%   -5.24%     
   ==========================================
     Files         828      392     -436     
     Lines       39162    24569   -14593     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        25681    14825   -10856     
   + Misses      13371     9744    -3627     
   + Partials      110        0     -110     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.34% <ø> (-0.61%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.70% <0.00%> (-0.14%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.56% <0.00%> (ø)` | |
   | [...rontend/src/components/ErrorMessage/ErrorAlert.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9FcnJvck1lc3NhZ2UvRXJyb3JBbGVydC50c3g=) | | |
   | [...-frontend/src/dashboard/util/isDashboardLoading.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvaXNEYXNoYm9hcmRMb2FkaW5nLmpz) | | |
   | ... and [440 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...e7cef06](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `4.54%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   61.02%   -4.55%     
   ==========================================
     Files         828      392     -436     
     Lines       39162    24574   -14588     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        25681    14997   -10684     
   + Misses      13371     9577    -3794     
   + Partials      110        0     -110     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.02% <ø> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <0.00%> (ø)` | |
   | [...perset-frontend/src/dashboard/util/findParentId.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvZmluZFBhcmVudElkLmpz) | | |
   | [...hboard/util/getChartAndLabelComponentIdFromPath.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvZ2V0Q2hhcnRBbmRMYWJlbENvbXBvbmVudElkRnJvbVBhdGguanM=) | | |
   | [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvc2VyaWFsaXplRmlsdGVyU2NvcGVzLmpz) | | |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvQ3NzRWRpdG9yLmpzeA==) | | |
   | [...ntend/src/dashboard/util/getRevertedFilterScope.ts](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvZ2V0UmV2ZXJ0ZWRGaWx0ZXJTY29wZS50cw==) | | |
   | [...tor-superset/superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZmVhdHVyZUZsYWdzLnRz) | | |
   | [...uperset/superset-frontend/src/explore/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb25zdGFudHMuanM=) | | |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvVGFibGVFbGVtZW50LmpzeA==) | | |
   | [...et-frontend/src/explore/controlPanels/DeckMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb250cm9sUGFuZWxzL0RlY2tNdWx0aS5qcw==) | | |
   | ... and [435 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...f4bc38c](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `5.61%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   59.96%   -5.62%     
   ==========================================
     Files         828      392     -436     
     Lines       39162    24558   -14604     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        25681    14725   -10956     
   + Misses      13371     9833    -3538     
   + Partials      110        0     -110     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `59.96% <ø> (-0.99%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.38% <0.00%> (-7.98%)` | :arrow_down: |
   | [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
   | [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `94.77% <0.00%> (-5.23%)` | :arrow_down: |
   | ... and [454 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...0575175](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `5.28%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   60.28%   -5.29%     
   ==========================================
     Files         828      392     -436     
     Lines       39162    24569   -14593     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        25681    14812   -10869     
   + Misses      13371     9757    -3614     
   + Partials      110        0     -110     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.28% <ø> (-0.66%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.74% <0.00%> (-0.83%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.56% <0.00%> (-0.28%)` | :arrow_down: |
   | [...dashboard/components/menu/MarkdownModeDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvbWVudS9NYXJrZG93bk1vZGVEcm9wZG93bi5qc3g=) | | |
   | [...set/superset-frontend/src/components/FormLabel.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9Gb3JtTGFiZWwudHN4) | | |
   | ... and [438 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...0575175](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `5.28%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   60.28%   -5.29%     
   ==========================================
     Files         828      392     -436     
     Lines       39162    24569   -14593     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        25681    14812   -10869     
   + Misses      13371     9757    -3614     
   + Partials      110        0     -110     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.28% <ø> (-0.66%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.74% <0.00%> (-0.83%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.56% <0.00%> (-0.28%)` | :arrow_down: |
   | [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvZ2V0RmlsdGVyVmFsdWVzQnlGaWx0ZXJJZC5qcw==) | | |
   | [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9FcnJvck1lc3NhZ2UvRXJyb3JNZXNzYWdlV2l0aFN0YWNrVHJhY2UudHN4) | | |
   | ... and [438 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...2993bd5](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11101: style(listview): various changes to get closer to SIP-34 designs.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101#issuecomment-705304840


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=h1) Report
   > Merging [#11101](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `4.51%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11101/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11101      +/-   ##
   ==========================================
   - Coverage   65.57%   61.06%   -4.52%     
   ==========================================
     Files         828      828              
     Lines       39162    39173      +11     
     Branches     3694     3690       -4     
   ==========================================
   - Hits        25681    23921    -1760     
   - Misses      13371    15071    +1700     
   - Partials      110      181      +71     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.28% <ø> (-0.02%)` | :arrow_down: |
   | #python | `60.34% <ø> (-0.61%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ator-superset/superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tor-superset/superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...r-superset/superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...superset/superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2luZGV4LmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...uperset/superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBDb2xvcnMuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY2hhcnQvQ2hhcnRDb250YWluZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...set/superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBGb3JtYXR0ZXJzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et/superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9yZWR1Y2Vycy9pbmRleC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...t/superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBQbHVnaW5zRXh0cmEuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [185 more](https://codecov.io/gh/apache/incubator-superset/pull/11101/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=footer). Last update [2a447ff...e7cef06](https://codecov.io/gh/apache/incubator-superset/pull/11101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org