You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/03 02:39:48 UTC
[GitHub] codecov-io commented on issue #5321: Add short URL link to dashboard
codecov-io commented on issue #5321: Add short URL link to dashboard
URL: https://github.com/apache/incubator-superset/pull/5321#issuecomment-401995522
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5321?src=pr&el=h1) Report
> Merging [#5321](https://codecov.io/gh/apache/incubator-superset/pull/5321?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/df5ce50e80fe83f4ed2551b1147d07c7ad1d7a95?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `53.84%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5321/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/5321?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5321 +/- ##
==========================================
- Coverage 61.32% 61.32% -0.01%
==========================================
Files 369 372 +3
Lines 23483 23563 +80
Branches 2717 2717
==========================================
+ Hits 14401 14450 +49
- Misses 9070 9101 +31
Partials 12 12
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5321?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset/assets/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5321/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXIuanN4) | `58.41% <ø> (ø)` | :arrow_up: |
| [...ard/deprecated/v1/components/URLShortLinkModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5321/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvZGVwcmVjYXRlZC92MS9jb21wb25lbnRzL1VSTFNob3J0TGlua01vZGFsLmpzeA==) | `0% <0%> (ø)` | |
| [...rc/dashboard/deprecated/v1/components/Controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5321/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvZGVwcmVjYXRlZC92MS9jb21wb25lbnRzL0NvbnRyb2xzLmpzeA==) | `0% <0%> (ø)` | :arrow_up: |
| [superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5321/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5321/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXJBY3Rpb25zRHJvcGRvd24uanN4) | `81.25% <100%> (+1.25%)` | :arrow_up: |
| [...t/assets/src/dashboard/util/getDashboardLongUrl.js](https://codecov.io/gh/apache/incubator-superset/pull/5321/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXREYXNoYm9hcmRMb25nVXJsLmpz) | `100% <100%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5321/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.87% <25%> (-0.1%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5321/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.22% <75%> (-0.08%)` | :arrow_down: |
| [...ets/src/dashboard/components/URLShortLinkModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5321/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9VUkxTaG9ydExpbmtNb2RhbC5qc3g=) | `88% <88%> (ø)` | |
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/5321/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.7% <0%> (-0.07%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/incubator-superset/pull/5321/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5321?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5321?src=pr&el=footer). Last update [df5ce50...d8ed0f7](https://codecov.io/gh/apache/incubator-superset/pull/5321?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org