You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/10/15 22:41:13 UTC
Review Request 63007: Replaced unnecessary future chaining in
api_tests.cpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63007/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
Instead of chaining response code check on a response future,
leverage `AWAIT_EXPECT_RESPONSE_STATUS_EQ` macro.
Diffs
-----
src/tests/api_tests.cpp 3d0db3b6c6bfb088a79921c3841ad312dad1ee6a
Diff: https://reviews.apache.org/r/63007/diff/1/
Testing
-------
See https://reviews.apache.org/r/63015/
Thanks,
Alexander Rukletsov
Re: Review Request 63007: Replaced unnecessary future chaining in
api_tests.cpp.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63007/#review188214
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Oct. 15, 2017, 3:41 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63007/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2017, 3:41 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of chaining response code check on a response future,
> leverage `AWAIT_EXPECT_RESPONSE_STATUS_EQ` macro.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 3d0db3b6c6bfb088a79921c3841ad312dad1ee6a
>
>
> Diff: https://reviews.apache.org/r/63007/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/63015/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>