You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/10 09:25:11 UTC
[GitHub] [superset] codecov[bot] commented on pull request #22659: fix(bootstrap-data): always check flashes
codecov[bot] commented on PR #22659:
URL: https://github.com/apache/superset/pull/22659#issuecomment-1376961641
# [Codecov](https://codecov.io/gh/apache/superset/pull/22659?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22659](https://codecov.io/gh/apache/superset/pull/22659?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d232629) into [master](https://codecov.io/gh/apache/superset/commit/5b2ca97341306b8b06ae55ff77eb2528a57f20ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5b2ca97) will **increase** coverage by `0.02%`.
> The diff coverage is `87.11%`.
> :exclamation: Current head d232629 differs from pull request most recent head 3bb7147. Consider uploading reports for the commit 3bb7147 to get more accurate results
```diff
@@ Coverage Diff @@
## master #22659 +/- ##
==========================================
+ Coverage 66.88% 66.90% +0.02%
==========================================
Files 1859 1869 +10
Lines 71103 71524 +421
Branches 7782 7814 +32
==========================================
+ Hits 47557 47855 +298
- Misses 21520 21628 +108
- Partials 2026 2041 +15
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `78.10% <95.12%> (+0.13%)` | :arrow_up: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.91% <95.12%> (-0.13%)` | :arrow_down: |
| unit | `51.51% <65.50%> (+0.08%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22659?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/embedded/view.py](https://codecov.io/gh/apache/superset/pull/22659?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZW1iZWRkZWQvdmlldy5weQ==) | `48.48% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/22659?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.28% <ø> (-0.16%)` | :arrow_down: |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/superset/pull/22659?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | `66.27% <ø> (ø)` | |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/22659?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `55.00% <50.00%> (-0.27%)` | :arrow_down: |
| [superset/dao/base.py](https://codecov.io/gh/apache/superset/pull/22659?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `92.78% <70.00%> (-2.62%)` | :arrow_down: |
| [...ews/CRUD/rowlevelsecurity/RowLevelSecurityList.tsx](https://codecov.io/gh/apache/superset/pull/22659?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvcm93bGV2ZWxzZWN1cml0eS9Sb3dMZXZlbFNlY3VyaXR5TGlzdC50c3g=) | `72.54% <72.54%> (ø)` | |
| [...ws/CRUD/rowlevelsecurity/RowLevelSecurityModal.tsx](https://codecov.io/gh/apache/superset/pull/22659?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvcm93bGV2ZWxzZWN1cml0eS9Sb3dMZXZlbFNlY3VyaXR5TW9kYWwudHN4) | `73.39% <73.39%> (ø)` | |
| [...ConfigModal/FiltersConfigForm/FilterScope/utils.ts](https://codecov.io/gh/apache/superset/pull/22659?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3V0aWxzLnRz) | `86.20% <87.50%> (-0.84%)` | :arrow_down: |
| [...uperset/row\_level\_security/commands/bulk\_delete.py](https://codecov.io/gh/apache/superset/pull/22659?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcm93X2xldmVsX3NlY3VyaXR5L2NvbW1hbmRzL2J1bGtfZGVsZXRlLnB5) | `88.00% <88.00%> (ø)` | |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/22659?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `87.96% <90.90%> (+0.66%)` | :arrow_up: |
| ... and [31 more](https://codecov.io/gh/apache/superset/pull/22659?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org