[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4450: libxx:uClibc++: disable new_handler.cpp when use libsupc++

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #4450:
URL: https://github.com/apache/incubator-nuttx/pull/4450#discussion_r700066926



##########
File path: libs/libxx/uClibc++.defs
##########
@@ -41,11 +41,15 @@ CPPSRCS += algorithm.cpp associative_base.cpp bitset.cpp char_traits.cpp
 CPPSRCS += complex.cpp del_op.cpp del_opnt.cpp del_ops.cpp del_opv.cpp
 CPPSRCS += del_opvnt.cpp del_opvs.cpp deque.cpp exception.cpp fstream.cpp
 CPPSRCS += func_exception.cpp iomanip.cpp ios.cpp iostream.cpp istream.cpp
-CPPSRCS += iterator.cpp limits.cpp list.cpp locale.cpp map.cpp new_handler.cpp
+CPPSRCS += iterator.cpp limits.cpp list.cpp locale.cpp map.cpp
 CPPSRCS += new_op.cpp new_opnt.cpp new_opv.cpp new_opvnt.cpp numeric.cpp
 CPPSRCS += ostream.cpp queue.cpp set.cpp sstream.cpp stack.cpp stdexcept.cpp
 CPPSRCS += streambuf.cpp string.cpp typeinfo.cpp utility.cpp valarray.cpp
 CPPSRCS += vector.cpp
 
+ifneq ($(CONFIG_LIBSUPCXX), y)
+  CPPSRCS += new_handler.cpp

Review comment:
       let's remove new_handler.cpp directly




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org