You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/10 14:45:08 UTC

[GitHub] [arrow] ayushpranjal-dremio commented on a diff in pull request #12306: ARROW-15083: [C++][Gandiva] Implement Conv Function

ayushpranjal-dremio commented on code in PR #12306:
URL: https://github.com/apache/arrow/pull/12306#discussion_r869330364


##########
cpp/src/gandiva/gdv_function_stubs.cc:
##########
@@ -296,6 +296,215 @@ CAST_NUMERIC_FROM_VARBINARY(double, arrow::DoubleType, FLOAT8)
 #undef GDV_FN_CAST_VARCHAR_INTEGER
 #undef GDV_FN_CAST_VARCHAR_REAL
 
+GDV_FORCE_INLINE
+int64_t unsigned_long_div(int64_t x, int32_t m) {

Review Comment:
   Add a comment on what this function is supposed to do. Also add unit tests for helper functions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org