You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2023/05/30 21:03:47 UTC

[native-toolchain-CR] IMPALA-12114: Incorporate patch for THRIFT-5705 for Thrift 0.16

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19957


Change subject: IMPALA-12114: Incorporate patch for THRIFT-5705 for Thrift 0.16
......................................................................

IMPALA-12114: Incorporate patch for THRIFT-5705 for Thrift 0.16

This brings in a basic fix for THRIFT-5705, a regression that
causes idle sessions to disconnect for Impala. This is not yet
merged to upstream Thrift, but hand tests confirm it fixes the
issue for Impala.

Testing:
 - Ran Thrift C++ tests on Thrift master branch with no issues

Change-Id: Ie809e99cfc8da25d65b1f546dbac3c27d3a42ff5
---
M buildall.sh
A source/thrift/thrift-0.16.0-patches/0004-THRIFT-5705-Don-t-accumulate-accumulate-retry-count-.patch
2 files changed, 104 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/57/19957/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie809e99cfc8da25d65b1f546dbac3c27d3a42ff5
Gerrit-Change-Number: 19957
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[native-toolchain-CR] IMPALA-12114: Incorporate patch for THRIFT-5705 for Thrift 0.16

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19957 )

Change subject: IMPALA-12114: Incorporate patch for THRIFT-5705 for Thrift 0.16
......................................................................

IMPALA-12114: Incorporate patch for THRIFT-5705 for Thrift 0.16

This brings in a basic fix for THRIFT-5705, a regression that
causes idle sessions to disconnect for Impala. This is not yet
merged to upstream Thrift, but hand tests confirm it fixes the
issue for Impala.

Testing:
 - Ran Thrift C++ tests on Thrift master branch with no issues

Change-Id: Ie809e99cfc8da25d65b1f546dbac3c27d3a42ff5
Reviewed-on: http://gerrit.cloudera.org:8080/19957
Reviewed-by: Jason Fehr <jf...@cloudera.com>
Reviewed-by: Riza Suminto <ri...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M buildall.sh
A source/thrift/thrift-0.16.0-patches/0004-THRIFT-5705-Don-t-accumulate-accumulate-retry-count-.patch
2 files changed, 104 insertions(+), 1 deletion(-)

Approvals:
  Jason Fehr: Looks good to me, but someone else must approve
  Riza Suminto: Looks good to me, approved
  Joe McDonnell: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie809e99cfc8da25d65b1f546dbac3c27d3a42ff5
Gerrit-Change-Number: 19957
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[native-toolchain-CR] IMPALA-12114: Incorporate patch for THRIFT-5705 for Thrift 0.16

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/19957 )

Change subject: IMPALA-12114: Incorporate patch for THRIFT-5705 for Thrift 0.16
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie809e99cfc8da25d65b1f546dbac3c27d3a42ff5
Gerrit-Change-Number: 19957
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 May 2023 16:44:25 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-12114: Incorporate patch for THRIFT-5705 for Thrift 0.16

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19957 )

Change subject: IMPALA-12114: Incorporate patch for THRIFT-5705 for Thrift 0.16
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie809e99cfc8da25d65b1f546dbac3c27d3a42ff5
Gerrit-Change-Number: 19957
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 May 2023 17:05:06 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-12114: Incorporate patch for THRIFT-5705 for Thrift 0.16

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19957 )

Change subject: IMPALA-12114: Incorporate patch for THRIFT-5705 for Thrift 0.16
......................................................................


Patch Set 2: Verified+1

My toolchain build passes, so going ahead with this


-- 
To view, visit http://gerrit.cloudera.org:8080/19957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie809e99cfc8da25d65b1f546dbac3c27d3a42ff5
Gerrit-Change-Number: 19957
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 May 2023 20:28:34 +0000
Gerrit-HasComments: No