You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "twosom (via GitHub)" <gi...@apache.org> on 2023/11/06 14:16:26 UTC
[PR] [Backport] Refactor CSVUtil to common analysis package [lucene]
twosom opened a new pull request, #12774:
URL: https://github.com/apache/lucene/pull/12774
### Description
This PR moves the CSVUtil class that existed separately in the Analyzer Nori and Kuromoji to the module :analysis:common. By consolidating the CSVUtil class, we can prevent duplication and improve maintainability across the Analyzer Nori and Kuromoji.
Closes #12773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] [Backport] Refactor CSVUtil to common analysis package [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand merged PR #12774:
URL: https://github.com/apache/lucene/pull/12774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] [Backport] Refactor CSVUtil to common analysis package [lucene]
Posted by "twosom (via GitHub)" <gi...@apache.org>.
twosom commented on PR #12774:
URL: https://github.com/apache/lucene/pull/12774#issuecomment-1796532473
> `gradle check` passes for me locally ... I'll push this and not sort out the Github actions. Thanks @twosom!
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] [Backport] Refactor CSVUtil to common analysis package [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on PR #12774:
URL: https://github.com/apache/lucene/pull/12774#issuecomment-1795590742
`gradle check` passes for me locally ... I'll push this and not sort out the Github actions. Thanks @twosom!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] [Backport] Refactor CSVUtil to common analysis package [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on PR #12774:
URL: https://github.com/apache/lucene/pull/12774#issuecomment-1795558334
Those failures were unrelated to this PR (I pushed a fix for them a short while ago). I'll try to kick off the checks again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org