You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Alessandro Presta (JIRA)" <ji...@apache.org> on 2012/10/31 00:28:13 UTC
[jira] [Created] (GIRAPH-393) Number of input split threads should
always be >= 1
Alessandro Presta created GIRAPH-393:
----------------------------------------
Summary: Number of input split threads should always be >= 1
Key: GIRAPH-393
URL: https://issues.apache.org/jira/browse/GIRAPH-393
Project: Giraph
Issue Type: Bug
Reporter: Alessandro Presta
Assignee: Alessandro Presta
When the number of input splits is less than the number of workers, integer division in the following snippet means we end up with 0:
{code}
int maxInputSplitThreads =
inputSplitPathList.size() / getConfiguration().getMaxWorkers();
int numThreads =
Math.min(getConfiguration().getNumInputSplitsThreads(),
maxInputSplitThreads);
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-393) Number of input split threads
should always be >= 1
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487602#comment-13487602 ]
Hudson commented on GIRAPH-393:
-------------------------------
Integrated in Giraph-trunk-Commit #259 (See [https://builds.apache.org/job/Giraph-trunk-Commit/259/])
GIRAPH-393: Number of input split threads should always be >= 1
(aching) (Revision 1403957)
Result = SUCCESS
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1403957
Files :
* /giraph/trunk/CHANGELOG
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
> Number of input split threads should always be >= 1
> ---------------------------------------------------
>
> Key: GIRAPH-393
> URL: https://issues.apache.org/jira/browse/GIRAPH-393
> Project: Giraph
> Issue Type: Bug
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Attachments: GIRAPH-393.patch
>
>
> When the number of input splits is less than the number of workers, integer division in the following snippet means we end up with 0:
> {code}
> int maxInputSplitThreads =
> inputSplitPathList.size() / getConfiguration().getMaxWorkers();
> int numThreads =
> Math.min(getConfiguration().getNumInputSplitsThreads(),
> maxInputSplitThreads);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-393) Number of input split threads should
always be >= 1
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-393:
-------------------------------
Attachment: GIRAPH-393.patch
My bad. Here is a fix.
> Number of input split threads should always be >= 1
> ---------------------------------------------------
>
> Key: GIRAPH-393
> URL: https://issues.apache.org/jira/browse/GIRAPH-393
> Project: Giraph
> Issue Type: Bug
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Attachments: GIRAPH-393.patch
>
>
> When the number of input splits is less than the number of workers, integer division in the following snippet means we end up with 0:
> {code}
> int maxInputSplitThreads =
> inputSplitPathList.size() / getConfiguration().getMaxWorkers();
> int numThreads =
> Math.min(getConfiguration().getNumInputSplitsThreads(),
> maxInputSplitThreads);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-393) Number of input split threads
should always be >= 1
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487448#comment-13487448 ]
Alessandro Presta commented on GIRAPH-393:
------------------------------------------
Thanks Avery. FWIW, this is also included in GIRAPH-155.
> Number of input split threads should always be >= 1
> ---------------------------------------------------
>
> Key: GIRAPH-393
> URL: https://issues.apache.org/jira/browse/GIRAPH-393
> Project: Giraph
> Issue Type: Bug
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Attachments: GIRAPH-393.patch
>
>
> When the number of input splits is less than the number of workers, integer division in the following snippet means we end up with 0:
> {code}
> int maxInputSplitThreads =
> inputSplitPathList.size() / getConfiguration().getMaxWorkers();
> int numThreads =
> Math.min(getConfiguration().getNumInputSplitsThreads(),
> maxInputSplitThreads);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-393) Number of input split threads
should always be >= 1
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487469#comment-13487469 ]
Avery Ching commented on GIRAPH-393:
------------------------------------
Sorry, I didn't look at GIRAPH-155. Committed this fix.
> Number of input split threads should always be >= 1
> ---------------------------------------------------
>
> Key: GIRAPH-393
> URL: https://issues.apache.org/jira/browse/GIRAPH-393
> Project: Giraph
> Issue Type: Bug
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Attachments: GIRAPH-393.patch
>
>
> When the number of input splits is less than the number of workers, integer division in the following snippet means we end up with 0:
> {code}
> int maxInputSplitThreads =
> inputSplitPathList.size() / getConfiguration().getMaxWorkers();
> int numThreads =
> Math.min(getConfiguration().getNumInputSplitsThreads(),
> maxInputSplitThreads);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-393) Number of input split threads
should always be >= 1
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487449#comment-13487449 ]
Alessandro Presta commented on GIRAPH-393:
------------------------------------------
+1, btw
> Number of input split threads should always be >= 1
> ---------------------------------------------------
>
> Key: GIRAPH-393
> URL: https://issues.apache.org/jira/browse/GIRAPH-393
> Project: Giraph
> Issue Type: Bug
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Attachments: GIRAPH-393.patch
>
>
> When the number of input splits is less than the number of workers, integer division in the following snippet means we end up with 0:
> {code}
> int maxInputSplitThreads =
> inputSplitPathList.size() / getConfiguration().getMaxWorkers();
> int numThreads =
> Math.min(getConfiguration().getNumInputSplitsThreads(),
> maxInputSplitThreads);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira