You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by ru...@apache.org on 2016/06/17 16:14:52 UTC
[whimsy] branch master updated: tighten scope of email search
This is an automated email from the ASF dual-hosted git repository.
rubys pushed a commit to branch master
in repository https://git-dual.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/master by this push:
new 2631cb2 tighten scope of email search
2631cb2 is described below
commit 2631cb2e416330e550a50e1531d6589ef533af28
Author: Sam Ruby <ru...@intertwingly.net>
AuthorDate: Fri Jun 17 12:14:36 2016 -0400
tighten scope of email search
---
www/board/agenda/views/elements/additional-info.js.rb | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/www/board/agenda/views/elements/additional-info.js.rb b/www/board/agenda/views/elements/additional-info.js.rb
index 39a5071..8d584b1 100644
--- a/www/board/agenda/views/elements/additional-info.js.rb
+++ b/www/board/agenda/views/elements/additional-info.js.rb
@@ -53,7 +53,7 @@ class AdditionalInfo < React
# compute date range for month
dfr = Date.parse(date.gsub('_', '-'))
- dto = Math.max(dfr + 31 * 86_400_000, Date.now())
+ dto = Math.min(dfr + 30 * 86_400_000, Date.now())
# convert to ISO format
dfr = Date.new(dfr).toISOString().substr(0,10)
@@ -62,9 +62,9 @@ class AdditionalInfo < React
# link to mail archive for feedback thread
if dfr > '2016-04'
_a '(thread)',
- href: 'https://lists.apache.org/list.html?board@apache.org:' +
- "d=dfr=#{dfr}|dto=#{dto}:" +
- "Board%20feedback%20on%20#{dfr}%20#{@@item.title}%20report"
+ href: 'https://lists.apache.org/list.html?board@apache.org&' +
+ "d=dfr=#{dfr}|dto=#{dto}&header_subject=" +
+ "'Board%20feedback%20on%20#{dfr}%20#{@@item.title}%20report'"
end
end
--
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <co...@whimsical.apache.org>'].
Re: [whimsy] branch master updated: tighten scope of email search
Posted by Sam Ruby <ru...@intertwingly.net>.
On Sat, Jun 18, 2016 at 6:13 AM, sebb <se...@gmail.com> wrote:
> On 17 June 2016 at 17:14, <ru...@apache.org> wrote:
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> rubys pushed a commit to branch master
>> in repository https://git-dual.apache.org/repos/asf/whimsy.git
>>
>> The following commit(s) were added to refs/heads/master by this push:
>> new 2631cb2 tighten scope of email search
>> 2631cb2 is described below
>>
>> commit 2631cb2e416330e550a50e1531d6589ef533af28
>> Author: Sam Ruby <ru...@intertwingly.net>
>> AuthorDate: Fri Jun 17 12:14:36 2016 -0400
>>
>> tighten scope of email search
>> ---
>> www/board/agenda/views/elements/additional-info.js.rb | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/www/board/agenda/views/elements/additional-info.js.rb b/www/board/agenda/views/elements/additional-info.js.rb
>> index 39a5071..8d584b1 100644
>> --- a/www/board/agenda/views/elements/additional-info.js.rb
>> +++ b/www/board/agenda/views/elements/additional-info.js.rb
>> @@ -53,7 +53,7 @@ class AdditionalInfo < React
>>
>> # compute date range for month
>> dfr = Date.parse(date.gsub('_', '-'))
>> - dto = Math.max(dfr + 31 * 86_400_000, Date.now())
>> + dto = Math.min(dfr + 30 * 86_400_000, Date.now())
>
> What about February?
> Or is that not why 30 days was chosen?
>
> We should document the reason for that magic number.
I've pushed a change which makes the upper limit to be today.
>> # convert to ISO format
>> dfr = Date.new(dfr).toISOString().substr(0,10)
>> @@ -62,9 +62,9 @@ class AdditionalInfo < React
>> # link to mail archive for feedback thread
>> if dfr > '2016-04'
>
> Another magic number - why that specific month?
> Does it need to be changed in future?
That's when sending feedback emails started.
>> _a '(thread)',
>> - href: 'https://lists.apache.org/list.html?board@apache.org:' +
>> - "d=dfr=#{dfr}|dto=#{dto}:" +
>> - "Board%20feedback%20on%20#{dfr}%20#{@@item.title}%20report"
>> + href: 'https://lists.apache.org/list.html?board@apache.org&' +
>> + "d=dfr=#{dfr}|dto=#{dto}&header_subject=" +
>> + "'Board%20feedback%20on%20#{dfr}%20#{@@item.title}%20report'"
>> end
>> end
>>
>>
>> --
>> To stop receiving notification emails like this one, please contact
>> ['"commits@whimsical.apache.org" <co...@whimsical.apache.org>'].
- Sam Ruby
Re: [whimsy] branch master updated: tighten scope of email search
Posted by sebb <se...@gmail.com>.
On 17 June 2016 at 17:14, <ru...@apache.org> wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> rubys pushed a commit to branch master
> in repository https://git-dual.apache.org/repos/asf/whimsy.git
>
> The following commit(s) were added to refs/heads/master by this push:
> new 2631cb2 tighten scope of email search
> 2631cb2 is described below
>
> commit 2631cb2e416330e550a50e1531d6589ef533af28
> Author: Sam Ruby <ru...@intertwingly.net>
> AuthorDate: Fri Jun 17 12:14:36 2016 -0400
>
> tighten scope of email search
> ---
> www/board/agenda/views/elements/additional-info.js.rb | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/www/board/agenda/views/elements/additional-info.js.rb b/www/board/agenda/views/elements/additional-info.js.rb
> index 39a5071..8d584b1 100644
> --- a/www/board/agenda/views/elements/additional-info.js.rb
> +++ b/www/board/agenda/views/elements/additional-info.js.rb
> @@ -53,7 +53,7 @@ class AdditionalInfo < React
>
> # compute date range for month
> dfr = Date.parse(date.gsub('_', '-'))
> - dto = Math.max(dfr + 31 * 86_400_000, Date.now())
> + dto = Math.min(dfr + 30 * 86_400_000, Date.now())
What about February?
Or is that not why 30 days was chosen?
We should document the reason for that magic number.
>
> # convert to ISO format
> dfr = Date.new(dfr).toISOString().substr(0,10)
> @@ -62,9 +62,9 @@ class AdditionalInfo < React
> # link to mail archive for feedback thread
> if dfr > '2016-04'
Another magic number - why that specific month?
Does it need to be changed in future?
> _a '(thread)',
> - href: 'https://lists.apache.org/list.html?board@apache.org:' +
> - "d=dfr=#{dfr}|dto=#{dto}:" +
> - "Board%20feedback%20on%20#{dfr}%20#{@@item.title}%20report"
> + href: 'https://lists.apache.org/list.html?board@apache.org&' +
> + "d=dfr=#{dfr}|dto=#{dto}&header_subject=" +
> + "'Board%20feedback%20on%20#{dfr}%20#{@@item.title}%20report'"
> end
> end
>
>
> --
> To stop receiving notification emails like this one, please contact
> ['"commits@whimsical.apache.org" <co...@whimsical.apache.org>'].