You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/02/20 18:32:55 UTC

[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #19928: [BUGFIX] Pip Build: use runtime.Features instead of manual check for mkldnn headers (#19195)

ChaiBapchya commented on a change in pull request #19928:
URL: https://github.com/apache/incubator-mxnet/pull/19928#discussion_r579691455



##########
File path: tools/pip/setup.py
##########
@@ -142,22 +142,16 @@ def skip_markdown_comments(md):
         libraries.append('CUDA-10.0')
     elif variant.startswith('CU92'):
         libraries.append('CUDA-9.2')
-    elif variant.startswith('CU91'):

Review comment:
       Are we dropping support for all cuda till 9? I guess yes [since cuda11 has launched and we support till latest major version-1]. Can we update the PR title to also reflect the same? Since currently it just talks about mkldnn and this PR changes things more than that.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org