You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "hehuiyuan (via GitHub)" <gi...@apache.org> on 2023/08/18 08:14:09 UTC
[GitHub] [hudi] hehuiyuan opened a new pull request, #9476: Add detail exception when instant transition state
hehuiyuan opened a new pull request, #9476:
URL: https://github.com/apache/hudi/pull/9476
### Change Logs
Add detail exception when instant transition state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #9476: Add detail exception when instant transition state
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #9476:
URL: https://github.com/apache/hudi/pull/9476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hehuiyuan commented on a diff in pull request #9476: Add detail exception when instant transition state
Posted by "hehuiyuan (via GitHub)" <gi...@apache.org>.
hehuiyuan commented on code in PR #9476:
URL: https://github.com/apache/hudi/pull/9476#discussion_r1301154093
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java:
##########
@@ -599,7 +599,7 @@ private void transitionState(HoodieInstant fromInstant, HoodieInstant toInstant,
protected void transitionState(HoodieInstant fromInstant, HoodieInstant toInstant, Option<byte[]> data,
boolean allowRedundantTransitions) {
- ValidationUtils.checkArgument(fromInstant.getTimestamp().equals(toInstant.getTimestamp()));
+ ValidationUtils.checkArgument(fromInstant.getTimestamp().equals(toInstant.getTimestamp()), String.format("%s and %s are not consistent when transition state.", fromInstant, toInstant));
Review Comment:
I'm not sure if it was caused by multiple writers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hehuiyuan commented on a diff in pull request #9476: Add detail exception when instant transition state
Posted by "hehuiyuan (via GitHub)" <gi...@apache.org>.
hehuiyuan commented on code in PR #9476:
URL: https://github.com/apache/hudi/pull/9476#discussion_r1301154093
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java:
##########
@@ -599,7 +599,7 @@ private void transitionState(HoodieInstant fromInstant, HoodieInstant toInstant,
protected void transitionState(HoodieInstant fromInstant, HoodieInstant toInstant, Option<byte[]> data,
boolean allowRedundantTransitions) {
- ValidationUtils.checkArgument(fromInstant.getTimestamp().equals(toInstant.getTimestamp()));
+ ValidationUtils.checkArgument(fromInstant.getTimestamp().equals(toInstant.getTimestamp()), String.format("%s and %s are not consistent when transition state.", fromInstant, toInstant));
Review Comment:
I'm not sure if it was caused by multiple writer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hehuiyuan commented on pull request #9476: Add detail exception when instant transition state
Posted by "hehuiyuan (via GitHub)" <gi...@apache.org>.
hehuiyuan commented on PR #9476:
URL: https://github.com/apache/hudi/pull/9476#issuecomment-1687472158
Hi @danny0405 , take a look when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9476: Add detail exception when instant transition state
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9476:
URL: https://github.com/apache/hudi/pull/9476#issuecomment-1683842078
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e63eb8d9bb4e9e002d76ed765ab11e1866f9abf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19351",
"triggerID" : "0e63eb8d9bb4e9e002d76ed765ab11e1866f9abf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e63eb8d9bb4e9e002d76ed765ab11e1866f9abf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19351)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #9476: Add detail exception when instant transition state
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #9476:
URL: https://github.com/apache/hudi/pull/9476#discussion_r1301101571
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java:
##########
@@ -599,7 +599,7 @@ private void transitionState(HoodieInstant fromInstant, HoodieInstant toInstant,
protected void transitionState(HoodieInstant fromInstant, HoodieInstant toInstant, Option<byte[]> data,
boolean allowRedundantTransitions) {
- ValidationUtils.checkArgument(fromInstant.getTimestamp().equals(toInstant.getTimestamp()));
+ ValidationUtils.checkArgument(fromInstant.getTimestamp().equals(toInstant.getTimestamp()), String.format("%s and %s are not consistent when transition state.", fromInstant, toInstant));
Review Comment:
The validation may make sense but when the two instant timestamp could be in-consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9476: Add detail exception when instant transition state
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9476:
URL: https://github.com/apache/hudi/pull/9476#issuecomment-1683564159
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e63eb8d9bb4e9e002d76ed765ab11e1866f9abf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19351",
"triggerID" : "0e63eb8d9bb4e9e002d76ed765ab11e1866f9abf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e63eb8d9bb4e9e002d76ed765ab11e1866f9abf Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19351)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9476: Add detail exception when instant transition state
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9476:
URL: https://github.com/apache/hudi/pull/9476#issuecomment-1683553788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0e63eb8d9bb4e9e002d76ed765ab11e1866f9abf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0e63eb8d9bb4e9e002d76ed765ab11e1866f9abf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0e63eb8d9bb4e9e002d76ed765ab11e1866f9abf UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org