You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by britter <gi...@git.apache.org> on 2017/06/14 08:26:12 UTC
[GitHub] commons-cli pull request #13: CLI-277: Add generics to TypeHandler
GitHub user britter opened a pull request:
https://github.com/apache/commons-cli/pull/13
CLI-277: Add generics to TypeHandler
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/britter/commons-cli CLI-277
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-cli/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit c17d0ff553fd34e2e53e0446083ee284ee97f6cb
Author: Benedikt Ritter <br...@apache.org>
Date: 2017-06-14T08:25:32Z
CLI-277: Add generics to TypeHandler
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-cli issue #13: CLI-277: Add generics to TypeHandler
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-cli/pull/13
[](https://:/builds/11962867)
Coverage remained the same at 96.244% when pulling **c17d0ff553fd34e2e53e0446083ee284ee97f6cb on britter:CLI-277** into **0b453953fa5f55cf2e8fd034d4d55972deb7647a on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-cli issue #13: CLI-277: Add generics to TypeHandler
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-cli/pull/13
+1 code in pull request looks good, tests too. But when I checked out the code to read it on Eclipse, I thought the class Javadoc a bit confusing.
```
* This is a temporary implementation. TypeHandler will handle the
* pluggableness of OptionTypes and it will direct all of these types
* of conversion functionalities to ConvertUtils component in Commons
* already. BeanUtils I think.
```
Haven't checked the git log, but after reading it, it sounds like this class is a temporary solution until another class is ready to be used as a replacement? I wonder if there is a class in some other component perhaps that we could use and maybe replace it? Or we can just update this javadoc later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-cli pull request #13: CLI-277: Add generics to TypeHandler
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-cli/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-cli pull request #13: CLI-277: Add generics to TypeHandler
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-cli/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org