You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2022/08/23 00:44:53 UTC
[Impala-ASF-CR](branch-4.1.1) IMPALA-11489: Fix int overflow in >2GB ORC files
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/18886
to review the following change.
Change subject: IMPALA-11489: Fix int overflow in >2GB ORC files
......................................................................
IMPALA-11489: Fix int overflow in >2GB ORC files
This can lead to returning an error "Invalid read len.", but can't lead
to other problems like reading corrupt data or crashing.
The fix is trivial, but creating automatic tests for it seems hard,
so no regression test is added.
Change-Id: Id8438d3512b0ebaafd319f369c1f6871d980a599
Reviewed-on: http://gerrit.cloudera.org:8080/18827
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Csaba Ringhofer <cs...@cloudera.com>
---
M be/src/exec/hdfs-orc-scanner.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/18886/1
--
To view, visit http://gerrit.cloudera.org:8080/18886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8438d3512b0ebaafd319f369c1f6871d980a599
Gerrit-Change-Number: 18886
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR](branch-4.1.1) IMPALA-11489: Fix int overflow in >2GB ORC files
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18886 )
Change subject: IMPALA-11489: Fix int overflow in >2GB ORC files
......................................................................
IMPALA-11489: Fix int overflow in >2GB ORC files
This can lead to returning an error "Invalid read len.", but can't lead
to other problems like reading corrupt data or crashing.
The fix is trivial, but creating automatic tests for it seems hard,
so no regression test is added.
Change-Id: Id8438d3512b0ebaafd319f369c1f6871d980a599
Reviewed-on: http://gerrit.cloudera.org:8080/18827
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Csaba Ringhofer <cs...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/18886
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/hdfs-orc-scanner.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8438d3512b0ebaafd319f369c1f6871d980a599
Gerrit-Change-Number: 18886
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR](branch-4.1.1) IMPALA-11489: Fix int overflow in >2GB ORC files
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18886 )
Change subject: IMPALA-11489: Fix int overflow in >2GB ORC files
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8438d3512b0ebaafd319f369c1f6871d980a599
Gerrit-Change-Number: 18886
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 10:06:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](branch-4.1.1) IMPALA-11489: Fix int overflow in >2GB ORC files
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18886 )
Change subject: IMPALA-11489: Fix int overflow in >2GB ORC files
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8438d3512b0ebaafd319f369c1f6871d980a599
Gerrit-Change-Number: 18886
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 15:28:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](branch-4.1.1) IMPALA-11489: Fix int overflow in >2GB ORC files
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18886 )
Change subject: IMPALA-11489: Fix int overflow in >2GB ORC files
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8438d3512b0ebaafd319f369c1f6871d980a599
Gerrit-Change-Number: 18886
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 10:58:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](branch-4.1.1) IMPALA-11489: Fix int overflow in >2GB ORC files
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18886 )
Change subject: IMPALA-11489: Fix int overflow in >2GB ORC files
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8489/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8438d3512b0ebaafd319f369c1f6871d980a599
Gerrit-Change-Number: 18886
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 10:58:07 +0000
Gerrit-HasComments: No