You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2022/08/31 09:59:36 UTC
[GitHub] [bigtop] kevinw66 opened a new pull request, #996: BIGTOP-3797: Support parent directory configuration for Kafka rpm build script
kevinw66 opened a new pull request, #996:
URL: https://github.com/apache/bigtop/pull/996
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'BIGTOP-3638: Your PR title ...'.
-->
### Description of PR
### How was this patch tested?
Tested with #994
diff result:
```
145374 blocks
145374 blocks
11 blocks
11 blocks
```
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
- [ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn merged pull request #996: BIGTOP-3797: Support parent directory configuration for Kafka rpm build script
Posted by GitBox <gi...@apache.org>.
sekikn merged PR #996:
URL: https://github.com/apache/bigtop/pull/996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #996: BIGTOP-3797: Support parent directory configuration for Kafka rpm build script
Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #996:
URL: https://github.com/apache/bigtop/pull/996#issuecomment-1243117715
Merged into master. Thanks @kevinw66!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #996: BIGTOP-3797: Support parent directory configuration for Kafka rpm build script
Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #996:
URL: https://github.com/apache/bigtop/pull/996#issuecomment-1243117394
+1, I confirmed that the package built with this PR (w/o `parentDir`) doesn't have any problematic difference from the original one.
```
[vagrant@rocky8 bigtop]$ ./gradlew kafka-clean kafka-pkg repo -Dbuildwithdeps=true
...
BUILD SUCCESSFUL in 3m 37s
19 actionable tasks: 19 executed
[vagrant@rocky8 bigtop]$ mv output/kafka ~
[vagrant@rocky8 bigtop]$ curl -sL https://github.com/apache/bigtop/pull/996.patch | git apply
...
[vagrant@rocky8 bigtop]$ ./gradlew kafka-clean kafka-pkg repo
...
BUILD SUCCESSFUL in 3m 30s
9 actionable tasks: 9 executed
[vagrant@rocky8 bigtop]$ for i in $(ls output/kafka/noarch); do diff <(rpm -qlp output/kafka/noarch/$i) <(rpm -qlp ~/kafka/noarch/$i); done
2d1
< /etc/kafka
```
It also passed the smoke test.
```
[vagrant@rocky8 docker]$ ./docker-hadoop.sh -d -C config_rockylinux-8.yaml -r file:///bigtop-home/output -G -k bigtop-utils,zookeeper,kafka -s kafka -c 3
...
> Task :bigtop-tests:smoke-tests:kafka:test
Finished generating test XML results (0.02 secs) into: /bigtop-home/bigtop-tests/smoke-tests/kafka/build/test-results/test
Generating HTML test report...
Finished generating test html results (0.042 secs) into: /bigtop-home/bigtop-tests/smoke-tests/kafka/build/reports/tests/test
Now testing...
:bigtop-tests:smoke-tests:kafka:test (Thread[Daemon worker,5,main]) completed. Took 13.318 secs.
BUILD SUCCESSFUL in 1m 44s
30 actionable tasks: 9 executed, 21 up-to-date
```
The contents in the package built with the `parentDir` option looks good too.
```
[vagrant@rocky8 bigtop]$ ./gradlew kafka-clean kafka-pkg -PparentDir=/usr/bigtop
...
BUILD SUCCESSFUL in 3m 33s
7 actionable tasks: 7 executed
[vagrant@rocky8 bigtop]$ for i in $(ls output/kafka/noarch); do echo $i; rpm -qlpv output/kafka/noarch/$i; echo; done
kafka-2.8.1-2.el8.noarch.rpm
drwxr-xr-x 2 kafka kafka 0 Sep 12 00:59 /etc/kafka
-rw-r--r-- 1 root root 0 Sep 12 00:59 /usr/bigtop/etc/default/kafka
drwxr-xr-x 2 root root 0 Sep 12 00:59 /usr/bigtop/etc/kafka/conf.dist
-rw-r--r-- 1 root root 4674 Sep 12 00:59 /usr/bigtop/etc/kafka/conf.dist/log4j.properties
-rw-r--r-- 1 root root 6849 Sep 14 2021 /usr/bigtop/etc/kafka/conf.dist/server.properties
-rw-r--r-- 1 root root 1032 Sep 14 2021 /usr/bigtop/etc/kafka/conf.dist/tools-log4j.properties
-rwxr-xr-x 1 root root 165 Sep 12 00:59 /usr/bigtop/usr/bin/kafka-console-consumer.sh
-rwxr-xr-x 1 root root 165 Sep 12 00:59 /usr/bigtop/usr/bin/kafka-console-producer.sh
-rwxr-xr-x 1 root root 158 Sep 12 00:59 /usr/bigtop/usr/bin/kafka-run-class.sh
-rwxr-xr-x 1 root root 155 Sep 12 00:59 /usr/bigtop/usr/bin/kafka-topics.sh
drwxr-xr-x 2 kafka kafka 0 Sep 12 00:59 /usr/bigtop/usr/lib/kafka
...
-rwxr-xr-x 1 kafka kafka 1019 Sep 14 2021 /usr/bigtop/usr/lib/kafka/bin/zookeeper-shell.sh
lrwxrwxrwx 1 kafka kafka 15 Sep 12 00:59 /usr/bigtop/usr/lib/kafka/config -> /etc/kafka/conf
drwxr-xr-x 2 kafka kafka 0 Sep 12 00:59 /usr/bigtop/usr/lib/kafka/libs
...
lrwxrwxrwx 1 kafka kafka 48 Sep 12 00:59 /usr/bigtop/usr/lib/kafka/libs/zookeeper-jute.jar -> /usr/bigtop/usr/lib/zookeeper/zookeeper-jute.jar
lrwxrwxrwx 1 kafka kafka 43 Sep 12 00:59 /usr/bigtop/usr/lib/kafka/libs/zookeeper.jar -> /usr/bigtop/usr/lib/zookeeper/zookeeper.jar
-rwxr-xr-x 1 kafka kafka 6474018 Sep 9 07:57 /usr/bigtop/usr/lib/kafka/libs/zstd-jni-1.4.9-1.jar
drwxr-xr-x 2 kafka kafka 0 Sep 12 00:59 /usr/bigtop/usr/lib/kafka/licenses
...
-rwxr-xr-x 1 kafka kafka 1360 Sep 14 2021 /usr/bigtop/usr/lib/kafka/licenses/zstd-jni-BSD-2-clause
lrwxrwxrwx 1 kafka kafka 14 Sep 12 00:59 /usr/bigtop/usr/lib/kafka/logs -> /var/log/kafka
drwxr-xr-x 2 root root 0 Sep 12 00:59 /usr/bigtop/usr/share/doc/kafka-2.8.1
...
-rw-r--r-- 1 root root 5987 Sep 14 2021 /usr/bigtop/usr/share/doc/kafka-2.8.1/site-docs/uses.html
drwxr-xr-x 2 kafka kafka 0 Sep 12 00:59 /usr/bigtop/var/lib/kafka
drwxr-xr-x 2 kafka kafka 0 Sep 12 00:59 /usr/bigtop/var/lib/kafka/data
drwxr-xr-x 2 kafka kafka 0 Sep 12 00:59 /var/log/kafka
drwxr-xr-x 2 kafka kafka 0 Sep 12 00:59 /var/run/kafka
kafka-server-2.8.1-2.el8.noarch.rpm
-rwxr-xr-x 1 root root 4938 Sep 12 00:59 /etc/rc.d/init.d/kafka-server
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org