You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/02/20 10:33:58 UTC
[GitHub] [incubator-apisix] membphis opened a new pull request #1143:
feature: modifying local configuration information is not allowed.
membphis opened a new pull request #1143: feature: modifying local configuration information is not allowed.
URL: https://github.com/apache/incubator-apisix/pull/1143
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on a change in pull request
#1143: feature: modifying local configuration information is not allowed.
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1143: feature: modifying local configuration information is not allowed.
URL: https://github.com/apache/incubator-apisix/pull/1143#discussion_r382341442
##########
File path: lua/apisix/core/table.lua
##########
@@ -81,4 +82,18 @@ end
_M.deepcopy = deepcopy
+function _M.readonly(t)
Review comment:
This function prohibits the insertion of new elements, but should it still be possible to modify existing data?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1143: feature:
modifying local configuration information is not allowed.
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1143: feature: modifying local configuration information is not allowed.
URL: https://github.com/apache/incubator-apisix/pull/1143#issuecomment-600982506
It looks a bit complicated, so close it first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis closed pull request #1143: feature:
modifying local configuration information is not allowed.
Posted by GitBox <gi...@apache.org>.
membphis closed pull request #1143: feature: modifying local configuration information is not allowed.
URL: https://github.com/apache/incubator-apisix/pull/1143
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1143: feature: modifying local configuration information is not allowed.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1143: feature: modifying local configuration information is not allowed.
URL: https://github.com/apache/incubator-apisix/pull/1143#discussion_r382414996
##########
File path: lua/apisix/core/table.lua
##########
@@ -81,4 +82,18 @@ end
_M.deepcopy = deepcopy
+function _M.readonly(t)
Review comment:
added more test case: https://github.com/apache/incubator-apisix/pull/1143/commits/9d0ffbe6cefe7dbd0ba70ae45baab007c89a39e5#diff-7e4b33723fb43f3a64bd46cb434958e7R67
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1143: feature: modifying local configuration information is not allowed.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1143: feature: modifying local configuration information is not allowed.
URL: https://github.com/apache/incubator-apisix/pull/1143#discussion_r382352828
##########
File path: lua/apisix/core/table.lua
##########
@@ -81,4 +82,18 @@ end
_M.deepcopy = deepcopy
+function _M.readonly(t)
Review comment:
> should it still be possible to modify existing data?
Modification of existing data is not allowed. I'll add new test case to confirm this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services