You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/27 15:05:56 UTC
[GitHub] [kafka] wcarlson5 opened a new pull request #11275: KAFKA-13128: extract retry checker
wcarlson5 opened a new pull request #11275:
URL: https://github.com/apache/kafka/pull/11275
add a new case for the flaky tests to take care of threads starting up
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on pull request #11275: KAFKA-13128: extract retry checker
Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on pull request #11275:
URL: https://github.com/apache/kafka/pull/11275#issuecomment-907270874
@lct45 @ableegoldman Can I get a quick look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #11275: KAFKA-13128: extract retry checker
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #11275:
URL: https://github.com/apache/kafka/pull/11275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on pull request #11275: KAFKA-13128: extract retry checker
Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on pull request #11275:
URL: https://github.com/apache/kafka/pull/11275#issuecomment-907555453
@ableegoldman lets get this merged. I will file a follow up ticket to make sure that this test has proper gating on the streams state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #11275: KAFKA-13128: extract retry checker
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on a change in pull request #11275:
URL: https://github.com/apache/kafka/pull/11275#discussion_r697778586
##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java
##########
@@ -543,22 +516,27 @@ public void shouldQueryStoresAfterAddingAndRemovingStreamThread() throws Excepti
assertThat(store1.get(key3), is(notNullValue()));
return true;
} catch (final InvalidStateStoreException exception) {
- assertThat(
- "Unexpected exception thrown while getting the value from store.",
- exception.getMessage(),
- is(
- anyOf(
- containsString("Cannot get state store source-table because the stream thread is PARTITIONS_ASSIGNED, not RUNNING"),
- containsString("The state store, source-table, may have migrated to another instance")
- )
- )
- );
+ verifyRetrievableException(exception);
LOG.info("Either streams wasn't running or a re-balancing took place. Will try again.");
return false;
}
});
}
+ private void verifyRetrievableException(final Exception exception) {
+ assertThat(
+ "Unexpected exception thrown while getting the value from store.",
+ exception.getMessage(),
+ is(
+ anyOf(
+ containsString("Cannot get state store source-table because the stream thread is PARTITIONS_ASSIGNED, not RUNNING"),
+ containsString("The state store, source-table, may have migrated to another instance"),
+ containsString("Cannot get state store source-table because the stream thread is STARTING, not RUNNING")
Review comment:
This particular exception has a different vibe than the above two: those are just unavoidable possibilities with IQ since Streams can start rebalancing at any time and there's no way to ensure that won't happen before/during a query. But failing due to a thread that's `STARTING` is in a different ballpark -- it's not like this can happen for no reason, and it should be possible to wait until all threads have finished startup before issuing a query. For example, we can just wait for Streams to reach RUNNING after adding a new thread, like we do when the client itself is first starting up.
(I'm not sure if the Streams state will transition to REBALANCING when a new thread is added, but it should.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org