You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "desaikomal (via GitHub)" <gi...@apache.org> on 2023/03/23 12:32:28 UTC
[GitHub] [helix] desaikomal opened a new pull request, #2418: Fix CI testcase failure: TestMultiZkConnection
desaikomal opened a new pull request, #2418:
URL: https://github.com/apache/helix/pull/2418
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
Fixes #2414
### Description
- [x] Here are some details about my PR
We have seen afterClass(org.apache.helix.integration.multizk.TestMultiZkConnectionConfig) failing. The possible cause is that TestMultiZkHelixJavaApis re-initializes the _zkClient connection. Parent class TestMultiZkConnectionConfig already creates _zkClient in beforeClass().
So it is possible that we have dangling zkclient which in the afterClass cleanup causes the failure.
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Testing Done:
[ERROR] Failures:
[ERROR] TestNoThrottleDisabledPartitions.testDisablingTopStateReplicaByDisablingInstance:98 expected:<false> but was:<true>
[ERROR] TestNoThrottleDisabledPartitions.testNoThrottleOnDisabledInstance:231->setupEnvironment:317->setupCluster:436 » ZkClient
[ERROR] TestRecurringJobQueue.stopDeleteJobAndResumeRecurrentQueue:123 » Helix Failed ...
[ERROR] TestRecurringJobQueue.testDeletingRecurrentQueueWithHistory:298 expected:<true> but was:<false>
[ERROR] TestClusterStatusMonitorLifecycle.testClusterStatusMonitorLifecycle:297 Remaining MBeans:
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on pull request #2418: Fix CI testcase failure: TestMultiZkConnection
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on PR #2418:
URL: https://github.com/apache/helix/pull/2418#issuecomment-1483920616
the same test cases are failing. so the fix is not correct. let me read the code again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] rahulrane50 commented on a diff in pull request #2418: Fix CI testcase failure: TestMultiZkConnection
Posted by "rahulrane50 (via GitHub)" <gi...@apache.org>.
rahulrane50 commented on code in PR #2418:
URL: https://github.com/apache/helix/pull/2418#discussion_r1146857478
##########
helix-core/src/test/java/org/apache/helix/integration/multizk/TestMultiZkHelixJavaApis.java:
##########
@@ -86,7 +86,7 @@ public class TestMultiZkHelixJavaApis extends TestMultiZkConnectionConfig {
@BeforeClass
public void beforeClass() throws Exception {
- super.beforeClass();
+ super.beforeApiClass();
Review Comment:
If my understanding is correct then you are bypassing _zkClient object creation from TestMultiZkConnectionConfig class. If that's true then we should add few null checks in TestMultiZkConnectionConfig.setupCluster or other methods. This is just to make sure that any user of TestMultiZkConnectionConfig now expects to initialize _zkClient object.
##########
helix-core/src/test/java/org/apache/helix/integration/multizk/TestMultiZkHelixJavaApis.java:
##########
@@ -86,7 +86,7 @@ public class TestMultiZkHelixJavaApis extends TestMultiZkConnectionConfig {
@BeforeClass
public void beforeClass() throws Exception {
- super.beforeClass();
+ super.beforeApiClass();
Review Comment:
Another point, i think we are not even using _zkClient anywhere in the test here right? if not we can completely remove it from this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on pull request #2418: Fix CI testcase failure: TestMultiZkConnection
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on PR #2418:
URL: https://github.com/apache/helix/pull/2418#issuecomment-1481611189
No @junkaixue - it is not about log statement. this was existing code. i just removed the _zkClient overwritten by beforeClass()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] rahulrane50 commented on a diff in pull request #2418: Fix CI testcase failure: TestMultiZkConnection
Posted by "rahulrane50 (via GitHub)" <gi...@apache.org>.
rahulrane50 commented on code in PR #2418:
URL: https://github.com/apache/helix/pull/2418#discussion_r1146857478
##########
helix-core/src/test/java/org/apache/helix/integration/multizk/TestMultiZkHelixJavaApis.java:
##########
@@ -86,7 +86,7 @@ public class TestMultiZkHelixJavaApis extends TestMultiZkConnectionConfig {
@BeforeClass
public void beforeClass() throws Exception {
- super.beforeClass();
+ super.beforeApiClass();
Review Comment:
If my understanding is correct then you are bypassing _zkClient object creation from TestMultiZkConnectionConfig class. If that's true then we should add few null checks in TestMultiZkConnectionConfig.setupCluster or other methods. This is just to make sure that any user of TestMultiZkConnectionConfig is now expected to initialize _zkClient object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal closed pull request #2418: Fix CI testcase failure: TestMultiZkConnection
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal closed pull request #2418: Fix CI testcase failure: TestMultiZkConnection
URL: https://github.com/apache/helix/pull/2418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a diff in pull request #2418: Fix CI testcase failure: TestMultiZkConnection
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on code in PR #2418:
URL: https://github.com/apache/helix/pull/2418#discussion_r1147063706
##########
helix-core/src/test/java/org/apache/helix/integration/multizk/TestMultiZkHelixJavaApis.java:
##########
@@ -86,7 +86,7 @@ public class TestMultiZkHelixJavaApis extends TestMultiZkConnectionConfig {
@BeforeClass
public void beforeClass() throws Exception {
- super.beforeClass();
+ super.beforeApiClass();
Review Comment:
we are using indirectly through base class. so i can't remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on pull request #2418: Fix CI testcase failure: TestMultiZkConnection
Posted by "junkaixue (via GitHub)" <gi...@apache.org>.
junkaixue commented on PR #2418:
URL: https://github.com/apache/helix/pull/2418#issuecomment-1481559888
Is this for adding some logs? Would be better use log instead of system print out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org